Skip to content

Removing note about Propel #13437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Conversation

ThomasLandauer
Copy link
Contributor

No description provided.

@javiereguiluz javiereguiluz added this to the 3.4 milestone Mar 30, 2020
@javiereguiluz
Copy link
Member

Thank you Thomas.

@javiereguiluz javiereguiluz merged commit 9cf277a into symfony:3.4 Mar 30, 2020
@ThomasLandauer ThomasLandauer deleted the patch-3 branch March 30, 2020 11:15
@ThomasLandauer
Copy link
Contributor Author

@javiereguiluz What about removing this entire "note" box? Doctrine is used throughout Symfony docs - no need to mention it each time.

In this article, it's loosely assumed that you're using Doctrine as your database store. But if you're not using Doctrine, it's all very similar. There are only a few parts of this tutorial that really care about "persistence".
If you are using Doctrine, you'll need to add the Doctrine metadata, including the ManyToMany association mapping definition on the Task's tags property.

@wouterj
Copy link
Member

wouterj commented Mar 30, 2020

This article is quite focussed on Doctrine (lots of hacking is needed to make things work properly with the ORM). So I think it makes sense to have this note in this specific document.

@javiereguiluz
Copy link
Member

Good question! Let's ask to @symfony/team-symfony-docs Thanks!

@ThomasLandauer
Copy link
Contributor Author

@wouterj OK. But it doesn't have to be that verbose, so I shortened it: #13439

javiereguiluz added a commit that referenced this pull request Apr 3, 2020
This PR was squashed before being merged into the 3.4 branch (closes #13439).

Discussion
----------

Shortening Doctrine Note

Follow up of #13437

Commits
-------

0f387d9 Shortening Doctrine Note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants