Skip to content

Update definitions.rst #13503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2020
Merged

Update definitions.rst #13503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0dc5efc
[Contributing] Fix `trigger_error()` position in deprecated class
fsoedjede Apr 7, 2020
142eb68
minor #13504 [Contributing] Fix `trigger_error()` position in depreca…
javiereguiluz Apr 10, 2020
31f99fe
Update definitions.rst
st-pham Apr 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contributing/code/conventions.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ the Web Debug Toolbar or by the PHPUnit bridge).
.. _`@-silencing operator`: https://php.net/manual/en/language.operators.errorcontrol.php

When deprecating a whole class the ``trigger_error()`` call should be placed
between the namespace and the use declarations, like in this example from
after the use declarations, like in this example from
`ServiceRouterLoader`_::

namespace Symfony\Component\Routing\Loader\DependencyInjection;
Expand Down
6 changes: 5 additions & 1 deletion service_container/definitions.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,14 +89,18 @@ fetched from the container::

// gets a specific argument
$firstArgument = $definition->getArgument(0);

// adds a new argument with the name of the argument
// $argumentName = the name of the argument in the constructor
$argument = $definition->setArgument('$argumentName', $argumentValue);

// adds a new argument
$definition->addArgument($argument);

// replaces argument on a specific index (0 = first argument)
$definition->replaceArgument($index, $argument);

// replace all previously configured arguments with the passed array
// replaces all previously configured arguments with the passed array
$definition->setArguments($arguments);

.. caution::
Expand Down