Skip to content

Add wither behavior with PHP8 static return type #13619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2020
Merged

Add wither behavior with PHP8 static return type #13619

merged 1 commit into from
Nov 5, 2020

Conversation

l-vo
Copy link
Contributor

@l-vo l-vo commented May 3, 2020 •
edited
Loading

close #13614

@l-vo l-vo mentioned this pull request May 3, 2020
Merged
@l-vo l-vo force-pushed the use_php8_static_return branch 2 times, most recently from 66527df to 4f4613d Compare May 3, 2020 19:47
javiereguiluz
javiereguiluz reviewed May 4, 2020
View reviewed changes
@l-vo l-vo force-pushed the use_php8_static_return branch from 4f4613d to c42130d Compare May 4, 2020 07:15
@l-vo
Copy link
Contributor Author

l-vo commented May 4, 2020

@javiereguiluz updated, thank you 🙂

@wouterj wouterj changed the base branch from master to 5.1 November 5, 2020 15:00
@wouterj wouterj force-pushed the use_php8_static_return branch from c42130d to 4bdab6f Compare November 5, 2020 15:00
wouterj added a commit that referenced this pull request Nov 5, 2020
@wouterj
[#13619] Moved text into a note and added versionadded
281d758
@wouterj wouterj merged commit 211ea43 into symfony:5.1 Nov 5, 2020
@wouterj
Copy link
Member

wouterj commented Nov 5, 2020

Thank you @l-vo for both the documentation and the code contribution!

wouterj added a commit that referenced this pull request Nov 5, 2020
@wouterj
Merge branch '5.1' into 5.x
e78aba4 
* 5.1:
  addressed issue #11786
  Add array example on ChoiceType choice_attr option
  [#13619] Moved text into a note and added versionadded
  Add wither behavior with PHP8 static return type
  [#14340] Some minor textual changes
  [Collection forms] Make javascript generic
  Updating the Installer Related Instructions
  Non-standard adder/remover methods
@l-vo l-vo deleted the use_php8_static_return branch November 5, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz left review comments

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support of PHP8 static return type for withers
4 participants
@l-vo @wouterj @javiereguiluz @carsonbot