Add documentation about RedisTagAwareAdapter #14081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4005be1 to
12ca50f
Compare
maxhelias
approved these changes
Aug 19, 2020
OskarStark
reviewed
Aug 26, 2020
OskarStark
requested changes
Aug 26, 2020
12ca50f to
83fe3d7
Compare
|
@OskarStark threads resolved, thank you 🙂 |
OskarStark
reviewed
Aug 26, 2020
| @@ -188,6 +188,20 @@ Available Options | |||
| When using the `Predis`_ library some additional Predis-specific options are available. | |||
| Reference the `Predis Connection Parameters`_ documentation for more information. | |||
|
|
|||
| .. _redis-tag-aware: | |||
There was a problem hiding this comment.
Suggested change
| .. _redis-tag-aware: | |
| .. _redis-tag-aware-adapter: |
OskarStark
reviewed
Aug 26, 2020
| @@ -58,6 +58,10 @@ To store tags, you need to wrap a cache adapter with the | |||
| :method:`Symfony\\Component\\Cache\\Adapter\\TagAwareAdapterInterface::invalidateTags` | |||
| method. | |||
|
|
|||
| .. note:: | |||
|
|
|||
| When using a Redis backend, consider using :ref:`RedisTagAwareAdapter <redis-tag-aware>` which is optimized for this purpose. | |||
There was a problem hiding this comment.
Suggested change
| When using a Redis backend, consider using :ref:`RedisTagAwareAdapter <redis-tag-aware>` which is optimized for this purpose. | |
| When using a Redis backend, consider using :ref:`RedisTagAwareAdapter <redis-tag-aware-adapter>` | |
| which is optimized for this purpose. |
|
@l-vo after my last two comments this is ready to merge 🙏 thank you for your patience |
|
I added my last two comments while merging 👍 Thank you! |
OskarStark
added a commit
that referenced
this pull request
Aug 26, 2020
OskarStark
added a commit
that referenced
this pull request
Aug 26, 2020
* 4.4: Minor: Rename ref. refs #14081 Add documentation about RedisTagAwareAdapter
OskarStark
added a commit
that referenced
this pull request
Aug 26, 2020
* 5.1: Minor: Rename ref. refs #14081 Add documentation about RedisTagAwareAdapter
OskarStark
added a commit
that referenced
this pull request
Aug 26, 2020
This PR was merged into the master branch. Discussion ---------- RedisTagAwareAdapter integration Documentation about symfony/symfony#36596 This PR contains documentation on `RedisTagAwareAdapter` (introduced in 4.3) **and** its integration in the fullstack framework (introduced in 5.2). I created another PR (#14081) with only the documentation about `RedisTagAwareAdapter` that targets 4.4. Close #14065 Commits ------- 883dc98 RedisTagAwareAdapter integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.