Skip to content

Added ability to use csv ips in security.access_control #14219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2020

Conversation

a-menshchikov
Copy link
Contributor

No description provided.

@javiereguiluz javiereguiluz added the Waiting Code Merge Docs for features pending to be merged label Sep 11, 2020
fabpot added a commit to symfony/symfony that referenced this pull request Sep 12, 2020
…ss_control (a-menshchikov)

This PR was squashed before being merged into the 5.2-dev branch.

Discussion
----------

[SecurityBundle] Comma separated ips for security.access_control

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        | symfony/symfony-docs#14219

There is currently no way to use env vars to configure `security.access_control` ips with multiple values. Ability to use comma separated ips make it able.

Commits
-------

0412e91 [SecurityBundle] Comma separated ips for security.access_control
symfony-splitter pushed a commit to symfony/security-bundle that referenced this pull request Sep 12, 2020
…ss_control (a-menshchikov)

This PR was squashed before being merged into the 5.2-dev branch.

Discussion
----------

[SecurityBundle] Comma separated ips for security.access_control

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        | symfony/symfony-docs#14219

There is currently no way to use env vars to configure `security.access_control` ips with multiple values. Ability to use comma separated ips make it able.

Commits
-------

0412e91060 [SecurityBundle] Comma separated ips for security.access_control
@OskarStark OskarStark added SecurityBundle and removed Waiting Code Merge Docs for features pending to be merged labels Sep 13, 2020
@OskarStark OskarStark added this to the 5.2 milestone Sep 13, 2020
wouterj added a commit that referenced this pull request Oct 3, 2020
@wouterj wouterj merged commit 02a814e into symfony:master Oct 3, 2020
@wouterj
Copy link
Member

wouterj commented Oct 3, 2020

Thanks @a-menshchikov!

I've merged the example you added with the example before in 14d9473 , to keep the documentation concise. Please let me know if you think important information has been lost :)

@a-menshchikov a-menshchikov deleted the security_csv_ips branch October 5, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants