Skip to content

[Validator] Add documentation for ULID validator #14350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2020
Merged

[Validator] Add documentation for ULID validator #14350

merged 1 commit into from
Oct 6, 2020

Conversation

laurent35240
Copy link
Contributor

Resolves #14298

Related to feature PR symfony/symfony#38322

@OskarStark OskarStark added this to the 5.2 milestone Oct 6, 2020
@xabbuh xabbuh changed the base branch from master to 5.x October 6, 2020 11:53
@xabbuh
Copy link
Member

xabbuh commented Oct 6, 2020

@laurent35240 You also need to add the new document to the toctree in reference/constraints.rst. That should fix the build error.

@OskarStark
Copy link
Contributor

OskarStark commented Oct 6, 2020 •
edited
Loading

Thank you Laurent.

@xabbuh I fixed the conflicts and added it to reference/constraints.rst 👍

@OskarStark OskarStark merged commit 4cd3283 into symfony:5.x Oct 6, 2020
@laurent35240
Copy link
Contributor Author

Thx @OskarStark
I will know for next time to add documentation in toctree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeahDude HeahDude Awaiting requested review from HeahDude

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Needs Review Validator
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

[Validator] Add Ulid constraint and validator
4 participants
@laurent35240 @xabbuh @OskarStark @carsonbot