Skip to content

Document routing inline requirements and defaults for host #14671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

julienfalque
Copy link
Contributor

Relates to symfony/symfony#37696.

Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fast response on closing the PR. This also made me realize your code feature was already merged, congrats!

👍 let's merge this as well :)

Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is ready, but shall we add an example? In the next major version the versionadded directives will be removed 🧐

@wouterj
Copy link
Member

wouterj commented Dec 9, 2020

Thank you @julienfalque for documenting the changes you proposed to the Symfony code!

@OskarStark is correct about adding an example (as the versionadded will be removed some time in the future). So I've done exactly that in 1ae411b (and also moved the information to the section talking about the host setting).

@julienfalque
Copy link
Contributor Author

Thanks @wouterj and @OskarStark!

@julienfalque julienfalque deleted the routing-host-inline branch December 9, 2020 10:49
wouterj added a commit that referenced this pull request Dec 10, 2020
* 5.2:
  Update setup page for Symfony 5.1 - add version
  Update setup page for Symfony 5.2 - drop dev
  [#14671] Added example of inline host defaults/requirements
  [#14672] Updated more docs related to the UserBadge
  Update experimental_authenticators : add UserBadge
  Document routing inline requirements and defaults for host
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants