Skip to content

[DependencyInjection] Fixing missing arguments #15462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ktherage
Copy link
Contributor

This PR aim to fix a missing arguments key in service configuration example.

@OskarStark OskarStark requested a review from wouterj June 23, 2021 18:40
@carsonbot carsonbot changed the title Fixing missing arguments [DependencyInjection] Fixing missing arguments Jun 25, 2021
@javiereguiluz
Copy link
Member

Thanks Kevin ... just asking: do you propose this change because the syntax is wrong or because you prefer the syntax with the arguments word in it? I'm asking because not adding arguments is valid ... I've just checked some Symfony apps of mine and sometimes I don't add arguments in some service configuration. Maybe I'm missing something here?

@HeahDude
Copy link
Contributor

HeahDude commented Jul 2, 2021

arguments can be omitted when it's the only key to be defined.
Ref symfony/symfony#21313 and #7441.
I would close this one.

@javiereguiluz
Copy link
Member

Thanks a lot Jules 🙏 That's the confirmation that we needed here. Let's close then. Thanks!

@ktherage ktherage deleted the patch-1 branch August 18, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants