[DependencyInjection] Add section about Service Closures #15730
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 19, 2021
374088f to
0da6fc7
Compare
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Aug 20, 2021
…-DSL (HypeMC) This PR was merged into the 5.4 branch. Discussion ---------- [DependencyInjection] Add service_closure() to the PHP-DSL | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | symfony/symfony-docs#15730 and symfony/symfony-docs#15731 Adds a `service_closure()` function to the PHP-DSL. Commits ------- f333fa0 [DI] Add service_closure() to the PHP-DSL
symfony-splitter
pushed a commit
to symfony/dependency-injection
that referenced
this pull request
Aug 20, 2021
…-DSL (HypeMC) This PR was merged into the 5.4 branch. Discussion ---------- [DependencyInjection] Add service_closure() to the PHP-DSL | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | symfony/symfony-docs#15730 and symfony/symfony-docs#15731 Adds a `service_closure()` function to the PHP-DSL. Commits ------- f333fa0e05 [DI] Add service_closure() to the PHP-DSL
HeahDude
approved these changes
Oct 1, 2022
Comment on lines
22
to
25
| /** | ||
| * @var \Closure | ||
| */ | ||
| private $mailer; |
There was a problem hiding this comment.
Suggested change
| /** | |
| * @var \Closure | |
| */ | |
| private $mailer; | |
| /** | |
| * @var callable(): MailerInterface | |
| */ | |
| private \Closure $mailer; |
?
| $services = $configurator->services(); | ||
|
|
||
| $services->set(MyService::class) | ||
| ->args([new ServiceClosureArgument(new Reference('mailer'))]); |
There was a problem hiding this comment.
Note to mergers: this should be updated to:
Suggested change
| ->args([new ServiceClosureArgument(new Reference('mailer'))]); | |
| ->args([service_closure('mailer')]); |
when merged up in 5.4.
There was a problem hiding this comment.
There's a separate PR for that #15731
OskarStark
reviewed
Oct 1, 2022
722e76e to
73125ee
Compare
|
As 4.4 is not maintained anymore we should only work on 5.4, can you merge the two PRs? |
|
@OskarStark Done, #15731 should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents service closures added in symfony/symfony#21770 and symfony/symfony#41176.