[DependencyInjection] Add section about Service Closures #15731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
562d799 to
1dea8a0
Compare
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Aug 20, 2021
…-DSL (HypeMC) This PR was merged into the 5.4 branch. Discussion ---------- [DependencyInjection] Add service_closure() to the PHP-DSL | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | symfony/symfony-docs#15730 and symfony/symfony-docs#15731 Adds a `service_closure()` function to the PHP-DSL. Commits ------- f333fa0 [DI] Add service_closure() to the PHP-DSL
symfony-splitter
pushed a commit
to symfony/dependency-injection
that referenced
this pull request
Aug 20, 2021
…-DSL (HypeMC) This PR was merged into the 5.4 branch. Discussion ---------- [DependencyInjection] Add service_closure() to the PHP-DSL | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | symfony/symfony-docs#15730 and symfony/symfony-docs#15731 Adds a `service_closure()` function to the PHP-DSL. Commits ------- f333fa0e05 [DI] Add service_closure() to the PHP-DSL
1dea8a0 to
822bcec
Compare
822bcec to
1e40081
Compare
OskarStark
reviewed
Oct 1, 2022
Comment on lines
96
to
97
| Using Service Closures in Compiler Passes | ||
| ----------------------------------------- |
There was a problem hiding this comment.
Suggested change
| Using Service Closures in Compiler Passes | |
| ----------------------------------------- | |
| Using Service Closures in Compiler Pass | |
| --------------------------------------- |
There was a problem hiding this comment.
Maybe even use Service Closure (singular) in the headline?
There was a problem hiding this comment.
What about "Using a Service Closures in a Compiler Pass"?
OskarStark
reviewed
Oct 1, 2022
OskarStark
reviewed
Oct 1, 2022
OskarStark
reviewed
Oct 1, 2022
OskarStark
reviewed
Oct 1, 2022
OskarStark
reviewed
Oct 1, 2022
OskarStark
reviewed
Oct 1, 2022
005216a to
8ab82c2
Compare
service_closure() function
ab6d0d0 to
b69cdaa
Compare
OskarStark
approved these changes
Mar 2, 2023
b69cdaa to
1958c06
Compare
service_closure() function
jdreesen
reviewed
Mar 8, 2023
f391a2c to
28f9b55
Compare
28f9b55 to
f2b2fdb
Compare
OskarStark
approved these changes
Mar 9, 2023
|
Thank you @HypeMC. |
HeahDude
reviewed
Mar 11, 2023
OskarStark
added a commit
to OskarStark/symfony-docs
that referenced
this pull request
Mar 11, 2023
OskarStark
added a commit
that referenced
this pull request
May 11, 2023
This PR was squashed before being merged into the 5.4 branch. Discussion ---------- Be consistent in code examples Follows #15731 (comment) cc `@HeahDude` Commits ------- 2426ce4 Be consistent in code examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents service closures added in symfony/symfony#21770 and symfony/symfony#41176, and the
service_closure()PHP-DSL function added in symfony/symfony#42625 .