Skip to content

[Validator] Add documentation for the Cidr Validator #15974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

popsorin
Copy link
Contributor

@popsorin popsorin commented Oct 21, 2021

Hello everyone!

This is the documentation for the Cidr validator and constraint.PR: symfony/symfony#43593

Please take a look and let me know if I need to change anything!

@popsorin popsorin force-pushed the feature/cidr-notation-constraint branch from 8528d2f to 16de4a9 Compare October 21, 2021 12:51
@xabbuh xabbuh added the Waiting Code Merge Docs for features pending to be merged label Oct 22, 2021
@carsonbot carsonbot modified the milestones: 5.4, next Oct 22, 2021
derrabus added a commit to symfony/symfony that referenced this pull request Oct 25, 2021
…IDR notations (popsorin)

This PR was merged into the 5.4 branch.

Discussion
----------

[Validator] Add CidrValidator to allow validation of CIDR notations

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #36526
| License       | MIT
| Doc PR        | symfony/symfony-docs#15974

This PR will add a CIDR Constraint Validator that will check if a string is a valid CIDR notation.

Commits
-------

488ff61 [Validator] Add CidrValidator to allow validation of CIDR notations
symfony-splitter pushed a commit to symfony/validator that referenced this pull request Oct 25, 2021
…IDR notations (popsorin)

This PR was merged into the 5.4 branch.

Discussion
----------

[Validator] Add CidrValidator to allow validation of CIDR notations

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #36526
| License       | MIT
| Doc PR        | symfony/symfony-docs#15974

This PR will add a CIDR Constraint Validator that will check if a string is a valid CIDR notation.

Commits
-------

488ff6187a [Validator] Add CidrValidator to allow validation of CIDR notations
@javiereguiluz javiereguiluz modified the milestones: next, 5.4 Nov 6, 2021
@javiereguiluz javiereguiluz added Status: Reviewed and removed Status: Needs Review Waiting Code Merge Docs for features pending to be merged labels Nov 6, 2021
@javiereguiluz javiereguiluz merged commit ed1c6f8 into symfony:5.4 Nov 6, 2021
@javiereguiluz
Copy link
Member

@popsorin thanks a lot for contributing this feature and for writing the docs for it. Congrats on your first Symfony Docs contribution too 🎉

Please note that while merging we made some minor tweaks (see f32ee43). They are mostly cosmetic or to comply with some rules that changed after you created this Pull Request (e.g. the removal of "options" from the table). In any case, your contribution was great! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants