-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Add functional test chapter to mailer #16195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The failing build is due to failing:
The problem is that |
This can be solved either here or upstream. Here
(note: not removing the vendor directory downgrades the dependencies back to UpstreamI think it would be cleaner to solve it upstream: Specify the symfony dependency in composer json: https://github.com/symfony-tools/symfony-application/blob/4.4/composer.json. For example, specify |
You are correct. Branch 4.4 on https://github.com/symfony-tools/symfony-application should install only version 4.4 of all symfony packages. Feel free to prepare a PR and I'll make sure to fix this ASAP. |
Could we rerun the CI? Either docs team restart it or @famoser runs:
|
Done, thanks for your help! I see that all PR from the last three days look stuck from the same issue we have just fixed. It might be quicker if the doc team could restart for all of them, rather than each one makes its own empty commit. |
I've notified the doc team. Thank you for testing and confirming that it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this PR. Well done!
There is just some syntax fixes.
PS. I know that if we asks the docs team nicely they will do syntax fixes for us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Thank you @famoser for making this PR and to debugging and fixing the CI.
Thank you very much, I appreciate your contribution and congratulations on your first contribution to the Symfony documentation 🎉 I made some minor adjustements while merging your PR 👍 |
Wohoo! |
Formulation largely from https://symfony.com/doc/4.4/email.html#how-to-test-that-an-email-is-sent-in-a-functional-test
Simple example which showcases the "global" methods like
assertEmailCount
and the e-mail specific assertions.Taken from actual code in use, so should be close to what user wants to accomplish.
Targets the 4.4 branch as described in the docs.
Resolves #14397