[Notifier] Add from in SmsMessage and support it in bridge transports #16701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These changes look totally unrelated 🙄 |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jul 26, 2022
This PR was merged into the 6.2 branch. Discussion ---------- [Notifier] Add `from` in `SmsMessage` | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #45435 | License | MIT | Doc PR | symfony/symfony-docs#16701 [WIP] This PR allow to define `From` in `SmsMessage`. When it defined, it override default `from` in transports. ```php $sms = new SmsMessage( // the phone number to send the SMS message to '+1411111111', // the message 'A new login was detected!', // [Optional] the From SMS message, it can also be a name '+1422222222', ); // Can also be defined with setter $sms->setFrom('+1422222222'); $sentMessage = $texter->send($sms); ``` Commits ------- 21b5051 [Notifier] Add from in SmsMessage and support it in bridge transports
|
The related code PR was merged: symfony/symfony#45987 🎉 @alamirault would you have time to finish this PR? If you can't fix the git issues with the unrelated commits, it's OK to delete this PR and create a new one. Thanks. |
|
I'm not sure where I have to do changes. Is edit SmsMessage example is enough ? https://github.com/symfony/symfony-docs/blame/6.2/notifier/texters.rst#L22 (Like in PR description) ? |
44aaa9e to
b911480
Compare
|
@javiereguiluz I rebased and changed documentation |
48313bc to
d627e1c
Compare
|
Thanks @alamirault! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If PR #45987 looks good. I will change docs