Skip to content

Ensure config blocks are consistent #16992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2022
Merged

Ensure config blocks are consistent #16992

merged 1 commit into from
Aug 9, 2022

Conversation

HeahDude
Copy link
Contributor

Given some more love to 4.4 before it's EOL.

To avoid tons of conflict when merging upstream, if accepted, it should be reverted in 5.4, I'll send PRs dedicated to 5.4..

@carsonbot carsonbot added this to the 4.4 milestone Jul 17, 2022
@HeahDude HeahDude force-pushed the fix-config-blocks branch from f306f85 to 3bdf7a7 Compare July 17, 2022 15:42
@HeahDude
Copy link
Contributor Author

I've missed those reported errors, at least some about XML are legit, I'll do a pass later to fix as many as I can.

@HeahDude HeahDude force-pushed the fix-config-blocks branch 2 times, most recently from a761377 to 877f275 Compare August 6, 2022 11:06
@HeahDude HeahDude mentioned this pull request Aug 6, 2022
Merged
@HeahDude
Copy link
Contributor Author

HeahDude commented Aug 6, 2022

As said Tobias, reported errors that remain are legit.

PR is ready.

javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Aug 8, 2022
@javiereguiluz
minor symfony#17121 Fix CI by reverting symfony#17020 (HeahDude)
f36cfb5 
This PR was merged into the 4.4 branch.

Discussion
----------

Fix CI by reverting symfony#17020

The CI is failing in symfony#16992 because of this, see https://github.com/symfony/symfony-docs/runs/7704382531?check_suite_focus=true.

My guess if that it's now fixed upstream thanks to symfony-tools/symfony-application#14.

Commits
-------

7c7c76e fix CI by reverting symfony#17020
@HeahDude HeahDude force-pushed the fix-config-blocks branch from 8fa4dab to 68aa9e1 Compare August 8, 2022 11:23
@javiereguiluz
Copy link
Member

Thanks a lot Jules!

@javiereguiluz javiereguiluz merged commit d24ec84 into symfony:4.4 Aug 9, 2022
@HeahDude HeahDude mentioned this pull request Aug 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@Nyholm Nyholm Nyholm left review comments

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@HeahDude @javiereguiluz @OskarStark @Nyholm @carsonbot