So

public function __construct(
   private Service $service
) {
}

is the formatting that should be used in the doc code examples?

Just asking because before opening the PR I found this disscusion in PR #17204 where you concluded that cpp should be done in the same code style as in the symfony code. And both the examples linked in the PR as well as previous PRs to the docs are formatted like:

public function __construct(private Service $service)
{
}

I'm just curious what's the preferred style for the docs going forward.

You are right, I think we keep them in one line if we have only on, but sometimes we keep many on one line too.

@javiereguiluz not sure how we should proceed in general with property promotion? As Code is meant to be executed and docs should be readable, I think we should line break them all the time.

WDYT @symfony/team-symfony-docs ?

I’d vote for a pragmatic middle based on line length: of the code gets too long (around the 70th char?) we break all args onto multiple lines. That’s usually what I do and it’ll keep the code blocks without needing to scroll horizontally

We've rejected CPP before: #17204 (comment) & #16087 (comment) But we also merged PRs adding CP... so I'm not sure what our policy is now.

About code style: we always follow Symfony CS (except that we care a bit more about not too long lines). In the Symfony CS, property promotion must always be on a multi line argument list.

CCP makes Code examples shorter and less noisy, so we should go for it.

👍 for multiline for readability

In this PR @nicolas-grekas is going the same direction

I fixed it while merging, thanks