Skip to content

[PropertyInfo] Fix PhpStanExtractor added version #18399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

colinodell
Copy link
Contributor

PhpStanExtractor was actually added in 5.4: symfony/symfony#40457 (comment)

@carsonbot
Copy link
Collaborator

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 5.4, 6.2, 6.3, 6.4, 7.0.

Cheers!

Carsonbot

@carsonbot carsonbot added this to the 6.1 milestone Jun 9, 2023
@colinodell colinodell changed the base branch from 6.1 to 6.2 June 9, 2023 19:45
@MrYamous
Copy link
Contributor

Nice catch, i think it can be rebased on 5.4 :)

@colinodell
Copy link
Contributor Author

i think it can be rebased on 5.4

This section of the documentation wasn't added until 6.1: #16955 (comment) I'm not sure why that decision was made, so I'm hesitant to backport this to 5.4.

@javiereguiluz javiereguiluz modified the milestones: 6.1, 6.2 Jun 12, 2023
@carsonbot carsonbot changed the title Fix PhpStanExtractor added version [PropertyInfo] Fix PhpStanExtractor added version Jun 12, 2023
@javiereguiluz javiereguiluz merged commit db084b4 into symfony:6.2 Jun 12, 2023
@javiereguiluz
Copy link
Member

Colin, thanks a lot for fixing this. Sadly, this was a bit tricky:

  • As Matthieu said, the best possible solution is to merge this in the (still supported) 5.4 branch
  • But as you said, this section was not added to 5.4, so it's cumbersome to move both the contents and the versionadded directive
  • Also, in 6.x docs we can't have 5.x versionadded directives (in 7.x we can't have 6.x versionadded, etc.)

So, while merging, I just removed the entire versionadded directive (see 7647318) because it's no longer needed in 6.x docs.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants