Skip to content

add OptionsResolverIntrospectorusage doc #18571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

PululuK
Copy link
Contributor

@PululuK PululuK commented Jul 17, 2023

Original commit : symfony/symfony@d6d187d
Orignal PR : symfony/symfony#24208

@OskarStark
Copy link
Contributor

Can you please reference the original Code PR? Thanks

@PululuK
Copy link
Contributor Author

PululuK commented Jul 17, 2023

Can you please reference the original Code PR? Thanks

Can you please help ? How can I do that ?

@OskarStark
Copy link
Contributor

Just add the link to the PR in this PR somewhere for a cross reference

@PululuK
Copy link
Contributor Author

PululuK commented Jul 17, 2023

Just add the link to the PR in this PR somewhere for a cross reference

Done !

@OskarStark
Copy link
Contributor

cc @yceruto

Copy link
Member

@yceruto yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@javiereguiluz javiereguiluz changed the base branch from 6.4 to 5.4 July 20, 2023 11:00
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner July 20, 2023 11:00
@javiereguiluz javiereguiluz force-pushed the add-OptionsResolverIntrospector-doc branch from ab25797 to 887f6f5 Compare July 20, 2023 11:00
@javiereguiluz javiereguiluz merged commit 5cf9008 into symfony:5.4 Jul 20, 2023
@javiereguiluz
Copy link
Member

@PululuK thanks a lot for improving the docs and for your patience during the review process. Congrats on your first Symfony Docs contribution 🎉

@PululuK PululuK deleted the add-OptionsResolverIntrospector-doc branch July 20, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants