Added Microsoft SQL Server Example to PDO session storage documentation #1926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Dependency Injection] small changes
I don't see any disadvantages for using a parameter here that *happens* to be used in the framework - the advantage is that it's meaningful for half the audience (and for component users, any parameter here will be a "generic")
| ( | ||
| [session_id] ASC | ||
| ) WITH (PAD_INDEX = OFF, STATISTICS_NORECOMPUTE = OFF, IGNORE_DUP_KEY = OFF, ALLOW_ROW_LOCKS = ON, ALLOW_PAGE_LOCKS = ON) ON [PRIMARY] | ||
| ) ON [PRIMARY] TEXTIMAGE_ON [PRIMARY] |
There was a problem hiding this comment.
A code block should be indented 4 spaces, not 2 or 3. I prefer to use the 72 characters break on code blocks to, can you split line 200 into multiple lines?
weaverryan
added a commit
that referenced
this pull request
Nov 23, 2012
weaverryan
added a commit
that referenced
this pull request
Nov 23, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title pretty much says it all, and Microsoft's SQL dialect is naturally different than MySQL/PostgreSQL.