Skip to content

[Console] Added documentation about command profiling #19265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

maelanleborgne
Copy link
Contributor

I just noticed the new --profile option wasn't documented (only on this blog post) yet, so here's a PR with just some minimal info added to the console page.

Copy link
Member

@alexandre-daubois alexandre-daubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, your lines seem long. You may try to break them at around 80 chars 🙂

@OskarStark
Copy link
Contributor

cc @HeahDude as you contributed the feature

Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting this feature, I've left some minors comments.

console.rst Outdated
Profiling Commands
------------------

When debug mode is enabled, you can run a command with the ``--profile`` option.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When debug mode is enabled, you can run a command with the ``--profile`` option.
When debug mode and the profiler are enabled, you can run a command with the ``--profile`` option.

console.rst Outdated
------------------

When debug mode is enabled, you can run a command with the ``--profile`` option.
Symfony will then collect data about the command's execution. When the execution
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Symfony will then collect data about the command's execution. When the execution
Symfony will then collect data about the command execution. When the execution

console.rst Outdated

When debug mode is enabled, you can run a command with the ``--profile`` option.
Symfony will then collect data about the command's execution. When the execution
is over, the profile is accessible through the :doc:`Symfony Profiler </profiler>`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
is over, the profile is accessible through the :doc:`Symfony Profiler </profiler>`.
is over, the profile is accessible through the web pages of the :doc:`Symfony Profiler </profiler>`.

@javiereguiluz javiereguiluz force-pushed the console/command-profiling branch from 8d58f82 to 4945d0a Compare December 15, 2023 12:31
@javiereguiluz javiereguiluz merged commit 8688b34 into symfony:6.4 Dec 15, 2023
@javiereguiluz
Copy link
Member

@maelanleborgne thanks and congrats on your first Symfony Docs contribution 🎉

While merging I did some minor reword (e.g. to move the terminal code example from inside the tip to the main content) but most of your contribution remained the same.

Thanks also to the reviewers for a very nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants