-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Console] Added documentation about command profiling #19265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Console] Added documentation about command profiling #19265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, your lines seem long. You may try to break them at around 80 chars 🙂
cc @HeahDude as you contributed the feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for documenting this feature, I've left some minors comments.
console.rst
Outdated
Profiling Commands | ||
------------------ | ||
|
||
When debug mode is enabled, you can run a command with the ``--profile`` option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When debug mode is enabled, you can run a command with the ``--profile`` option. | |
When debug mode and the profiler are enabled, you can run a command with the ``--profile`` option. |
console.rst
Outdated
------------------ | ||
|
||
When debug mode is enabled, you can run a command with the ``--profile`` option. | ||
Symfony will then collect data about the command's execution. When the execution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Symfony will then collect data about the command's execution. When the execution | |
Symfony will then collect data about the command execution. When the execution |
console.rst
Outdated
|
||
When debug mode is enabled, you can run a command with the ``--profile`` option. | ||
Symfony will then collect data about the command's execution. When the execution | ||
is over, the profile is accessible through the :doc:`Symfony Profiler </profiler>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is over, the profile is accessible through the :doc:`Symfony Profiler </profiler>`. | |
is over, the profile is accessible through the web pages of the :doc:`Symfony Profiler </profiler>`. |
8d58f82
to
4945d0a
Compare
@maelanleborgne thanks and congrats on your first Symfony Docs contribution 🎉 While merging I did some minor reword (e.g. to move the terminal code example from inside the tip to the main content) but most of your contribution remained the same. Thanks also to the reviewers for a very nice work! |
I just noticed the new
--profile
option wasn't documented (only on this blog post) yet, so here's a PR with just some minimal info added to the console page.