[Cache] Fix redis adapter config to work with tags #19996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicolas-grekas This applies to 5.4 too, right? |
|
@xabbuh you are right. This is available since 5.2: symfony/symfony#36596 |
|
Thank you @Huluti. |
|
I'm sorry but this change looks wrong to me. I just created a small app and the previous snippet works well. |
|
@Huluti did you use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that to work with redis and tags using this config was not working (tag not set and invalidation not working):
While with this one all was working fine:
Up to you if you think that it makes sense :)