[FrameworkBundle] Remove default value for gc_probability config option
#20204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gc_probability config option
MrYamous
reviewed
Sep 6, 2024
| @@ -1852,6 +1852,8 @@ started on every session initialization. The probability is calculated by | |||
| using ``gc_probability`` / ``gc_divisor``, e.g. 1/100 means there is a 1% | |||
| chance that the GC process will start on each request. | |||
|
|
|||
| If not set, ``php.ini``'s `session.gc_probability`_ directive will be relied on. | |||
There was a problem hiding this comment.
Maybe with a versionadded directive to indicate this is a new behavior ?
And we also need to remove default value few lines above
There was a problem hiding this comment.
Thanks for the feedback ! Just committed your recommandations.
cfb03e7 to
31a33bf
Compare
|
Merged! Raphaël thanks a lot for this contribution ... and congrats on your first Symfony Docs contribution 🎉 |
Thank you for pointing me those 'good first issues' ! I'm glad I could take a first step in the symfony-docs contribution 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20196