-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Cookbook] [Routing] Custom route loader #2338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
matthiasnoback
wants to merge
28
commits into
symfony:master
from
matthiasnoback:cookbook_custom_route_loader
Closed
[Cookbook] [Routing] Custom route loader #2338
matthiasnoback
wants to merge
28
commits into
symfony:master
from
matthiasnoback:cookbook_custom_route_loader
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not explicitly clear that a higher priority number means the method is called earlier. Add some verbiage to that effect.
…at we have 2.0, 2.1, 2.2 and master
| Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | symfony#2290
[symfony#2273] Add valid values for currency
Fix two minor typos in the contributing section
…cher Add a clarification to the event subscriber section
…-bump [2.0] Re-working contributing language for 2.2 branch
[Book] Fixed highlighting issues
add some minor interpunction fixes for consistency
…rJ-patch-13 Conflicts: contributing/documentation/overview.rst
…rm_option [Typo] Fixing typo in date_format form option description
Do not work anymore.
[symfony#2290] Single command apps with arguments
…and explains how to override the getDefinition method
Sorry, something went wrong when making the pull request - I'm not sure what though. Could anybody help please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a new cookbook article about custom route loaders (see also #526). Feedback is much appreciated.
There is a small difference for version 2.1:
should be changed to
As well as the corresponding
use
at the top.How should I add this to my pull request?