Skip to content

[Cookbook] [Routing] Custom route loader #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

matthiasnoback
Copy link
Contributor

I've created a new cookbook article about custom route loaders (see also #526). Feedback is much appreciated.

There is a small difference for version 2.1:

public function setResolver(LoaderResolver $resolver)

should be changed to

public function setResolver(LoaderResolverInterface $resolver)

As well as the corresponding use at the top.

How should I add this to my pull request?

ricardclau and others added 28 commits February 5, 2013 17:21
It's not explicitly clear that a higher priority number means the method is called earlier. Add some verbiage to that effect.
| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | symfony#2290
Fix two minor typos in the contributing section
…cher

Add a clarification to the event subscriber section
…-bump

[2.0] Re-working contributing language for 2.2 branch
add some minor interpunction fixes for consistency
…rJ-patch-13

Conflicts:
	contributing/documentation/overview.rst
…rm_option

[Typo] Fixing typo in date_format form option description
Do not work anymore.
…and explains how to override the getDefinition method
@matthiasnoback
Copy link
Contributor Author

Sorry, something went wrong when making the pull request - I'm not sure what though. Could anybody help please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants