Skip to content

Fix YAML syntax so the parser renders the colors correctly #2437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2013

Conversation

lucascourot
Copy link
Contributor

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets #945

yml syntax highlighting

Without quotes, the parser doesn't render the syntax highlighting correctly
Without quotes, the parser doesn't render the syntax highlighting correctly
@wouterj
Copy link
Member

wouterj commented Mar 31, 2013

👍 (see also #1886 if you want to fix more highlighting problems :) )

@@ -162,7 +162,7 @@ in the previous example takes the ``templating`` service as an argument:
factory_service: newsletter_factory
factory_method: get
arguments:
- @templating
- "@templating"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should remove the useless spaces in this line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there useless spaces in this line? They are useful for the indentation with the previous values.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but those values our not on the same level. I mean, if it was this:

foo:
    foobarlormeipumshelloworld: Lorem
    bar: Hello World

I prefer to do it like this:

foo:
    foobarlormeipumshelloworld: Lorem
    bar:                        Hello World

But in this case, we have something like:

foo:
    foobarlorremipsumhellowlrd: Lorem
    bar:
        cat: Hello World

Now, Hello World should not get lined up with Lorem, because it's on a new level.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, have a look at my last commit please lucascourot@e1ae126

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wouterj
Copy link
Member

wouterj commented Apr 1, 2013

👍

@weaverryan weaverryan merged commit e1ae126 into symfony:2.0 Apr 9, 2013
@weaverryan
Copy link
Member

Hi Lucas!

This is awesome - very very nice work!

Thanks!

@wouterj
Copy link
Member

wouterj commented Apr 10, 2013

@weaverryan could you pleaes give your opinion on how you think we should solve this same problem with the HTML/XML examples? (#1886)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants