-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Fix YAML syntax so the parser renders the colors correctly #2437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lucascourot
commented
Mar 31, 2013
Q | A |
---|---|
Doc fix? | yes |
New docs? | no |
Applies to | all |
Fixed tickets | #945 |
syntax highlighting correctly
Without quotes, the parser doesn't render the syntax highlighting correctly
Without quotes, the parser doesn't render the syntax highlighting correctly
👍 (see also #1886 if you want to fix more highlighting problems :) ) |
@@ -162,7 +162,7 @@ in the previous example takes the ``templating`` service as an argument: | |||
factory_service: newsletter_factory | |||
factory_method: get | |||
arguments: | |||
- @templating | |||
- "@templating" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should remove the useless spaces in this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there useless spaces in this line? They are useful for the indentation with the previous values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but those values our not on the same level. I mean, if it was this:
foo:
foobarlormeipumshelloworld: Lorem
bar: Hello World
I prefer to do it like this:
foo:
foobarlormeipumshelloworld: Lorem
bar: Hello World
But in this case, we have something like:
foo:
foobarlorremipsumhellowlrd: Lorem
bar:
cat: Hello World
Now, Hello World
should not get lined up with Lorem
, because it's on a new level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, have a look at my last commit please lucascourot@e1ae126
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
👍 |
Hi Lucas! This is awesome - very very nice work! Thanks! |
@weaverryan could you pleaes give your opinion on how you think we should solve this same problem with the HTML/XML examples? (#1886) |