Skip to content

[Forms] Fix submit button usage in template #3082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2013
Merged

[Forms] Fix submit button usage in template #3082

merged 1 commit into from
Nov 2, 2013

Conversation

bicpi
Copy link
Contributor

@bicpi bicpi commented Oct 22, 2013

Q A
Doc fix? yes
New docs? no
Applies to 2.3
Fixed tickets -

In the controller above the form was built with the new "submit" field type, so the submit button should be rendered with the "form_widget()" Twig function following the field type reference. Otherwise the "form_end()" function will render it in addition to the plain HTML "input[type=submit]" button.

weaverryan added a commit that referenced this pull request Nov 2, 2013
[Forms] Fix submit button usage in template
@weaverryan weaverryan merged commit b85a9a1 into symfony:2.3 Nov 2, 2013
@weaverryan
Copy link
Member

Ah, very nice catch!

And yes... I've been seeing you're PR's - I think 26 open PR's is a new record (by far) :). Looking forward to merging them, hopefully many tomorrow.

Cheers!

@bicpi
Copy link
Contributor Author

bicpi commented Nov 2, 2013

Whats the badge name for this record? ;-)

Yes, lots of PRs, but only very small fixes; got a lot more on my list, if you want them :-)

@wouterj
Copy link
Member

wouterj commented Nov 2, 2013

Nooo, you beat my record of 15 PRs before the merge day... 👊

The most funny fact is that you haven't received the doc contributor badge yet 😆

@bicpi
Copy link
Contributor Author

bicpi commented Nov 4, 2013

I could have bet that I've received a notification some time ago that I've been awarded with the documentation contributor badge - but you're right, no badge in my profile. Still missing another Symfony Day badge, too.

And I don't see how my Sensio profile can be linked from the Contributors page and show my avatar - cannot find a setting for this. Moreover, I'm listed on position 77., 230. and 294. in the "All Time" list - rather strange... 😐

@wouterj
Copy link
Member

wouterj commented Nov 4, 2013

It all uses the sensiolabs connect account. I think the problem is that you commit using 'Philipp Reiber', but you linked your sensiolabs connect account to @bicpi

@bicpi
Copy link
Contributor Author

bicpi commented Nov 4, 2013

So I would need to change git config user.name?

But how can this be applied for commits in the past - would be really nice to get this right.

@xabbuh
Copy link
Member

xabbuh commented Nov 4, 2013

Maybe it is enough to add your e-mail address to your SensioLabs Connect account.You can do that on your profile page.

@wouterj
Copy link
Member

wouterj commented Nov 4, 2013

You can't edit commits in the past, sorry

@bicpi
Copy link
Contributor Author

bicpi commented Nov 4, 2013

I've just added my GitHub email address and the address I've commited with to my SensioLabs Connect account, maybe that helps... Mh, would be strange if everything depends on the the git config user.name because I don't see why it should not differ from the GitHub username.

@xabbuh
Copy link
Member

xabbuh commented Nov 4, 2013

I don't think that it relies on the user.name, but on the user.emailoption. Furthermore, you should see the SensioLabs Connect application in the list of authorized applications in your GitHub account.

@bicpi
Copy link
Contributor Author

bicpi commented Nov 4, 2013

SensioLabs Connect is in the list of authorized applications (and was before) of GitHub.
I've added some email addresses to my SensioLabs Connect profile that I'm using on other machines, so I'll have to wait until the list gets rebuilt I think.

Really appriciate your help, thank you!

@bicpi
Copy link
Contributor Author

bicpi commented Nov 4, 2013

I've just skimmed over all my doc contributions and found that I've really used three different email addresses for user.email. Now that I've added all these addresses to my SensioLabs Connect profile I hope this gets fixed automatically :-)

@cordoval
Copy link
Contributor

cordoval commented Nov 4, 2013

👶

@bicpi
Copy link
Contributor Author

bicpi commented Nov 7, 2013

Thank you guys! All my commits have been summed up, my SensioLabs Connect profile is linked and I've been awarded with the constributor badges for docs and code 😄 Just needed to add all those old email addresses and wait some days.

@bicpi bicpi deleted the fix_submit_button branch January 5, 2014 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants