-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Forms] Fix submit button usage in template #3082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[Forms] Fix submit button usage in template
Ah, very nice catch! And yes... I've been seeing you're PR's - I think 26 open PR's is a new record (by far) :). Looking forward to merging them, hopefully many tomorrow. Cheers! |
Whats the badge name for this record? ;-) Yes, lots of PRs, but only very small fixes; got a lot more on my list, if you want them :-) |
Nooo, you beat my record of 15 PRs before the merge day... 👊 The most funny fact is that you haven't received the doc contributor badge yet 😆 |
I could have bet that I've received a notification some time ago that I've been awarded with the documentation contributor badge - but you're right, no badge in my profile. Still missing another Symfony Day badge, too. And I don't see how my Sensio profile can be linked from the Contributors page and show my avatar - cannot find a setting for this. Moreover, I'm listed on position 77., 230. and 294. in the "All Time" list - rather strange... 😐 |
It all uses the sensiolabs connect account. I think the problem is that you commit using 'Philipp Reiber', but you linked your sensiolabs connect account to @bicpi |
So I would need to change But how can this be applied for commits in the past - would be really nice to get this right. |
Maybe it is enough to add your e-mail address to your SensioLabs Connect account.You can do that on your profile page. |
You can't edit commits in the past, sorry |
I've just added my GitHub email address and the address I've commited with to my SensioLabs Connect account, maybe that helps... Mh, would be strange if everything depends on the the git config |
I don't think that it relies on the |
Really appriciate your help, thank you! |
I've just skimmed over all my doc contributions and found that I've really used three different email addresses for |
👶 |
Thank you guys! All my commits have been summed up, my SensioLabs Connect profile is linked and I've been awarded with the constributor badges for docs and code 😄 Just needed to add all those old email addresses and wait some days. |
In the controller above the form was built with the new "submit" field type, so the submit button should be rendered with the "form_widget()" Twig function following the field type reference. Otherwise the "form_end()" function will render it in addition to the plain HTML "input[type=submit]" button.