-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Updated installation instructions to use the new Symfony Installer #4580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated installation instructions to use the new Symfony Installer #4580
Conversation
javiereguiluz
commented
Dec 3, 2014
Q | A |
---|---|
Doc fix? | yes |
New docs? | yes |
Applies to | all |
Fixed tickets | - |
I think it should be mentioned that the installer requires php-5.4 instead of 5.3 as symfony. Running it on 5.3 will give a syntax error
|
@1ed thanks for reporting this error. Ironically, we have a special error message for people not using PHP 5.4: https://github.com/symfony/symfony-installer/blob/master/src/Symfony/Installer/NewCommand.php#L78-89 Does anyone know how to display this error before displaying the syntax error related to Guzzle using 5.4? |
@javiereguiluz The issue is that the Composer autoloader immediately loads all files that are registered under a package's autoload files key. |
I've just made a quick test, it can be made via a custom stub file. I will get back to it later and create a PR or an issue at symfony-installer. |
@1ed Sorry, I didn't read your comment before, but submitted a pull request in the meantime: symfony/symfony-installer#66 |
why not providing installing using composer and using the installer? |
@timglabisch I'm not sure about adding alternatives. The point of "Best Practices" is to have (ideally) just one recommended way of doing things. If that's the case, the installer is definitely the thing to recommend. |
@javiereguiluz you're right, in the context of best practice we just should add a notice that you can use composer if you want. |
@@ -1,53 +1,42 @@ | |||
Creating the Project | |||
==================== | |||
|
|||
Installing Symfony | |||
------------------ | |||
Symfony Installer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should still say "Installing Symfony", that's the task you have to do in this section. "Symfony Installer" is no longer a task, making the section more of a wiki than a step by step tutorial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. Done!
I've addressed the comments made above. Please, if you can, merge this PR as soon as possible because it's important to have updated and accurate installation instructions. Thanks! |
|
||
Dependency Management with Composer | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
Linux and Mac OS X systems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Systems
👍 |
Very nice work. 👍 |
…y Installer (javiereguiluz) This PR was merged into the 2.3 branch. Discussion ---------- Updated installation instructions to use the new Symfony Installer | Q | A | ------------- | --- | Doc fix? | yes | New docs? | yes | Applies to | all | Fixed tickets | - Commits ------- f58db71 Fixed section headers 4b8e805 Restored the original section title b69a5cd Updated installation instructions to use the new Symfony Installer
Very nicely written Javier, and quite concise too :). I just opened #4672 to track todos towards getting down to just one installation method. It includes actually removing much of what's in this, but that would be once symfony.com/download has the new instructions (which I'm sure will use much of the nice language used here). Thanks! |