-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Updated installation instructions to use the new Symfony Installer #4580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
weaverryan
merged 3 commits into
symfony:2.3
from
javiereguiluz:update_installation_practices
Dec 20, 2014
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think of making tabs for this?
bash-unix
,bash-windows
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea, but we don't have resources to do it now. I prefer to merge this PR as soon as possible and then improve things like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All we would have to do is to add labels for the new tabs to the
conf.py
file which you would need to deploy on the build server. Is that still a hard task to do?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still remember the "varnish tabs" nightmare and the "best practice tab" horror story. I'm afraid that I'm too old to still believe that anything related to software is easy or it will work at first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your point. You know the build process better than I do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javiereguiluz couldn't the build process import the conf.py available in the doc repo and then overwrite only the settings it needs to change ? This would avoid you to change the build config for such changes done by the doc team to add new syntax highlightings for instance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stof what we're really going to do is to remove from the best practices book all the explanations regarding how to install Symfony and create the application. Soon we'll change the current "Use Composer to install Symfony" practice for "Use the Symfony Installer to create Symfony apps". We won't explain anything else because the book explains all in detail.
But while we change that, this PR is a quick fix to the problem of not explaining correctly how to install Symfony. That's why I'd love to see it merged soon :)