-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Use AppBundle instead of AcmeDemoBundle for consistency #5086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👍 |
Nice catch @snamor. 👍 |
Thanks! Read the book 3 times and this is the first time I see this... I'll notify if I find more typos :) |
Will the plan be to get rid of all Acme occurences? Found a lot more of them ;) https://github.com/symfony/symfony-docs/search?utf8=%E2%9C%93&q=Acme |
@rvanlaak some uses of the |
You're right 👍 maybe this is something for the 3.0 branch? |
@rvanlaak doing it only for the 3.0 branch is even worse for maintenance because it will make it impossible to merge branches together. The right way to handle this is to send a PR updating 1 chapter (and making sure there is no pending PR doing it already). And it is easier to start with chapters which don't have a pending PR (no conflict for them). However, for such task, it is better to ask the doc maintainers first to know their plan (they might want to update some parts first for instance) |
Yea, wow - great catch @snamor! And yea, we're working through the sections one-by-one. There's nothing wrong with something like AcmeDemoBundle, so we're migrating a section at a time. Keeping individual sections accurate and consistent is the key :). But of course, if someone finds an entry that doesn't use AppBundle and wants to change all the occurrences in that entry, that's a huge help! Cheers! |
…snamor) This PR was merged into the 2.3 branch. Discussion ---------- Use AppBundle instead of AcmeDemoBundle for consistency Commits ------- 6a437b6 Use AppBundle instead of AcmeDemoBundle for consistency
No description provided.