Skip to content

Use AppBundle instead of AcmeDemoBundle for consistency #5086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2015
Merged

Use AppBundle instead of AcmeDemoBundle for consistency #5086

merged 1 commit into from
Mar 24, 2015

Conversation

snamor
Copy link
Contributor

@snamor snamor commented Mar 17, 2015

No description provided.

@stof
Copy link
Member

stof commented Mar 17, 2015

👍

@xabbuh
Copy link
Member

xabbuh commented Mar 17, 2015

Nice catch @snamor. 👍

@snamor
Copy link
Contributor Author

snamor commented Mar 17, 2015

Thanks! Read the book 3 times and this is the first time I see this... I'll notify if I find more typos :)

@rvanlaak
Copy link
Contributor

Will the plan be to get rid of all Acme occurences? Found a lot more of them ;)

https://github.com/symfony/symfony-docs/search?utf8=%E2%9C%93&q=Acme

@javiereguiluz
Copy link
Member

@rvanlaak some uses of the Acme vendor may be legitimate. We must evaluate them on a case by case basis. In any case, one thing we don't want is a massive PR which makes thousands of small changes across documentation. That kind of PR really complicates the work of our dear doc maintainers.

@rvanlaak
Copy link
Contributor

You're right 👍 maybe this is something for the 3.0 branch?

@stof
Copy link
Member

stof commented Mar 18, 2015

@rvanlaak doing it only for the 3.0 branch is even worse for maintenance because it will make it impossible to merge branches together.

The right way to handle this is to send a PR updating 1 chapter (and making sure there is no pending PR doing it already). And it is easier to start with chapters which don't have a pending PR (no conflict for them). However, for such task, it is better to ask the doc maintainers first to know their plan (they might want to update some parts first for instance)

@weaverryan
Copy link
Member

Yea, wow - great catch @snamor! And yea, we're working through the sections one-by-one. There's nothing wrong with something like AcmeDemoBundle, so we're migrating a section at a time. Keeping individual sections accurate and consistent is the key :). But of course, if someone finds an entry that doesn't use AppBundle and wants to change all the occurrences in that entry, that's a huge help! Cheers!

@weaverryan weaverryan merged commit 6a437b6 into symfony:2.3 Mar 24, 2015
weaverryan added a commit that referenced this pull request Mar 24, 2015
…snamor)

This PR was merged into the 2.3 branch.

Discussion
----------

Use AppBundle instead of AcmeDemoBundle for consistency

Commits
-------

6a437b6 Use AppBundle instead of AcmeDemoBundle for consistency
@snamor snamor deleted the 2.3 branch March 25, 2015 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants