[HttpKernel] Added support for registering Bundle dependencies #5103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
| by implementing "BundleDependenciesInterface" interface:: | ||
|
|
||
| // src/Acme/UserBundle/AcmeCacheBundle.php | ||
| namespace Acme\CacheBundle; |
There was a problem hiding this comment.
Ok, note that this is the case in inheritance.rst
|
Thank you for writing this nice article, @andrerom! I left 2 more comments (you're quick with the fixes!). You also have to add this article to |
|
Thanks for the review, I have updated the things you pointed out. Might be I misunderstood on things like removing vendor or the :'class: syntax for instance, but should be ready for second look now 😄 |
| bundle more tedious for your users. | ||
|
|
||
| You can avoid this by specifying your dependencies, this will make sure | ||
| they are loaded, and *before* your own bundle to make sure you can extend |
There was a problem hiding this comment.
"You can avoid this by specifying your dependencies. This will make sure that they are loaded in the kernel. It'll also make sure they are loaded before your own bundle, to make sure you can extend the bundle." (other than extending a bundle, it doesn't have to be loaded before afaik)
There was a problem hiding this comment.
fixed, with one twist. I did not end the sentence with "bundle", but instead "them" as the subject is the dependencies so that felt clearer, might be even more clearer by consistently saying *the dependencies". ok?
|
Apart from some minor things 👍 |
|
Updated, including rebased. |
| ==================================================== | ||
|
|
||
| .. versionadded:: 2.7 | ||
| Bundle dependencies was introduced in Symfony 2.7. |
There was a problem hiding this comment.
Imo it's Was, as it's one feature.
There was a problem hiding this comment.
Then we should reword this to something like "Support for bundle dependencies was introduced [...]"
68b8183 to
471d149
Compare
3 tasks
…ated position of depreciation notes
…lidation constraint (peterrehm) This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes symfony#4354). Discussion ---------- [WCM] Added depreciation note for the cascade_validation constraint | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.8 | Fixed tickets | - This PR was based on symfony/symfony#12237 and has been updated based as symfony/symfony#15019. symfony#4348 Commits ------- 22a87b5 Added depreciation note for the cascade_validation constraint and updated position of depreciation notes
* 2.7: [symfony#5426] Porting the checkDNS option to 2.7 only Reordered the configuration blocks of the first example Fixed some errors and made some simplifications Added the "payload" option back (was removed by mistake) Fixed the order of the examples Simplified the first example and added more examples [Validator] Updated documentation of URL validator Fixed typos Removed duplication and moved a caution message [Console] Added a cookbook entry on invoking other commands [symfony#5367] Making the titles more searchable fix symfony#5487 [FrameworkBundle] Update serializer configuration reference Changed Authorization and Authentication to use subsections Split Security into Authentication & Authorization
* 2.7: [symfony#5456] Updating for Symfony 2.7 Adding an example of how the other format for attaching transformers looks fixed typo thanks to @OskarStark adding use statement using the aliases entity manager service name Many tweaks thanks to review Completely re-reading the data transformers chapter:
* 2.7: (21 commits) [symfony#5352] minor language tweak Updated text about HTTP methods Update http_fundamentals.rst [HttpKernel] Fix use statement [PSR-7] Fix Diactoros link Fixes small typo in data transformers cookbook some tweaks to the data transformers chapter Updated the Symfony Versions Roadmap image Fixed a minor typo Fixed minor issues Use the built-in serializer instead of promoting JMS Removed some information wrongly rebased Style / grammar fixes for the deployment chapter Style / grammar fixes for the controller chapter Style / grammar fixes for the console chapter Removes wrong comma Rewritten 'whether' & removed serial comma Style / grammar fixes for the configuration chapter Style / grammar fixes for the cache chapter Style / grammar fixes for the bundles chapter ...
* 2.7: Reworded a note about BC Added a note about the implementation of the verbosity semantic methods Fixed some minor syntax issues. Reflect links correctly in gmail.rst Revisions to the gmail.rst doc Update gmail.rst Minor grammar fix. Fix RST
…n server:start
* 2.7: Document Platform.sh on the contributing section. Mention Platform.sh on README. Better Sphinx version. Improve configuration files. Prepare Platform.sh configuration files.
* 2.7: [symfony#5444] Fixing missing public: false declarations and proofing [Book][Routing] Change example to match multiple methods Fixed an error in the auto_alias format value Fixed RST table syntax Reverted an unneeded change Minor grammar issue Minor fixes Remove the old voter article Rewrite new section Move access decision strategy section Fixed some errors and added a new note Removed an extra blank line Added the "versionadded: 2.7" directive Documented the "auto_alias" feature Minor reword Improved the explanation about the verbosity levels of the console
This PR was merged into the 2.8 branch. Discussion ---------- HTML5 range documentation Hi, | Q | A | ------------- | --- | Doc fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Fixed tickets | [symfony#5439] | Code PR | [12607] | License | MIT I am trying to contribute to range added for the PR symfony/symfony#12067 & symfony/symfony#11979 which fixes symfony#5439 . Need some help on moving for I am really new to the documentation. The current issues I feel is whether we need to add Basic usage or is that only reference ? I had a look at http://symfony.com/doc/current/reference/forms/types/number.html which would have been similar, but that seems it referencing to choice seems more confusing. I have looked into other types also and almost all are some what similar. Any input is highly appreciated and will work on in the free time. If someone is interested please do take the PR or finish it . Thank you. Commits ------- 2863079 Fix moving the mapped down as per @xabbuh abf3e8e Fix the rendering issue 3c6ff76 Fix issues reported by @snoek09 . Thank you. a2c3f21 Make the necessary changes mentioned by @xabbuh and add example for form d4d1f12 Starting with range documentation
* 2.7: [symfony#5472] Minor tweak and adding code example [symfony#5453] Minor tweaks - mostly thanks to Javier Reword Fix caching Fix build Added a tip about hashing the result of nextBytes() rework the quick tour's big picture fix for Symfony 2.7 Fix after install URL and new photo since AcmeDemoBundle is not part of 2.7 Improve travis build speed
… the --force option (vincentaubert) This PR was merged into the 2.8 branch. Discussion ---------- [Cookbook][WebServer] symfony#5504 add a tip for the --force option | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.8 | Fixed tickets | symfony#5504 Commits ------- b88a17e [Cookbook][WebServer] symfony#5504 add a tip for the --force option on server:start
… container scopes (javiereguiluz) This PR was merged into the 2.8 branch. Discussion ---------- [WIP] Added caution notes about the deprecation of container scopes | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.8+ | Fixed tickets | symfony#5436 This is a first proposal related to scopes deprecation. Questions: * Should we expand the "caution notes" to explain why we did that and the alternatives provided? * Should we rewrite the `cookbook/service_container/scopes.rst` article to explain the new scopes + shared flag and add a note about the old scopes which were available in the past Symfony versions? Commits ------- 99a996c Added caution notes about the deprecation of container scopes
* 2.7: Ensure that the entity is updated. Update lazy_services.rst Update templating.rst Additional little check to show how we're assumign the User object is the User entity Moved mongodb article and cleanup Fixing remaining reference of old emplacement of pdo_session_storage page due to the rebase Move some articles from wrong sections, updated indexs Move some articles from wrong sections [symfony#5374] Add deprecation notice in 2.7 fix YAML syntax highlighting Improve and simplify the contributing instructions about tests Some fixes for bundle best practices Fix Major upgrade article for 2.7.1 changes [symfony#5413] Backporting changes to 2.3
|
Closed, updated, and moved to new PR for 2.8: #5610 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo: