-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[HttpKernel] Added support for registering Bundle dependencies #5610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
andrerom
commented
Aug 9, 2015
Q | A |
---|---|
Doc fix? | no |
New docs? | yes symfony/symfony#15011 |
Applies to | 2.8 |
Fixed tickets |
Updated to reflect updated PR, review ping @wouterj, @weaverryan, @xabbuh. _new/changed lines: 24-25, 30-35, 67-_* |
09fe35f
to
fea98af
Compare
Additional use case for this is for distribution bundle use cases where one | ||
bundle is in fact bundling several others. | ||
|
||
Specifying dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Specifying Dependencies" (title case rules are to capitialize every word, except from closed-class words)
fea98af
to
de226c8
Compare
----------------------- | ||
|
||
Dependencies are specified using a Fully Qualified Name for the bundle class in same | ||
format as PHP uses for ``get_class`` and for ``class`` constant introduced in PHP 5.5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should class
be written in uppercase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http://php.net/manual/en/language.oop5.basic.php#language.oop5.basic.class.class
I can add this link to the word here to make that, and the feature itself more clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added link in 3877991
thank you @andrerom |
714fb9a
to
25b0351
Compare
Thanks @wouterj and @OskarStark, updated. |
f01806a
to
fad2060
Compare
👍 |
|
||
.. _FQN: https://en.wikipedia.org/wiki/Fully_qualified_name | ||
.. _get_class: http://php.net/manual/en/function.get-class.php | ||
.. _class: http://php.net/manual/en/language.oop5.basic.php#language.oop5.basic.class.class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
links should be at the bottom of the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 2968dc2
fad2060
to
2968dc2
Compare
Closing as the related PR has just been closed. |