[Cache] Doc context aware adapters, aka hierarchical invalidation #6858

nicolas-grekas · 2016-08-06T23:14:25Z

No description provided.

nicolas-grekas · 2016-08-07T08:28:39Z

I'd happily accept any suggestions for making the explanations more detailed. It's hard to write doc when things seem obvious because you wrote the code...

wouterj · 2016-08-07T09:07:40Z

components/cache/cache_invalidation.rst

+- expiration based invalidation for time related dependencies.
+
+.. versionadded:: 3.2
+    Tags and namespace based invalidation were introduced in Symfony 3.2.


I believe it should be "was" here, as it's refering to "X based invalidation", which is singular.

wouterj · 2016-08-07T09:47:49Z

components/cache/cache_invalidation.rst

+invalidation version number (conceptually similar to their latest invalidation
+date). When only one adapter is used, items and tags are all stored in the same
+place. By using two adapters, you can e.g. store some big cached items on the
+filesystem or in the database, and keep tags in a Redis database to sync all your


please remove the serial comma before "and keep"

wouterj · 2016-08-07T09:51:48Z

Sorry, was distracted for some time during the review of this PR. I've now finished reviewing this article, thanks for documenting this feature!

status: needs work

Koc · 2016-08-07T10:28:17Z

How to configure tag aware cache using framework config?

nicolas-grekas · 2016-08-07T11:07:17Z

@Koc I don't know yet :) would need a PR on FrameworkBundle.

…TagAwareRedisAdapter) (nicolas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [Cache] Add generic TagAwareAdapter wrapper (replaces TagAwareRedisAdapter) | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#6858 This PR replaces TagAwareRedisAdapter introduced in #19047 by a generic `TagAwareAdapter` that works with any two adapters. Commits ------- 288308b [Cache] Add generic TagAwareAdapter wrapper (replaces TagAwareRedisAdapter)

mickaelandrieu · 2016-08-09T20:23:15Z

components/cache/cache_invalidation.rst

+    // or invalidate all items related to `tag_1` or `tag_3`
+    $cache->invalidateTags(array('tag_1', 'tag_3'));
+
+Of course when you know the cache key, it's better to call


I would reword that this way:

Using Cache tags invalidation is very useful when you don't need to know the cache key to delete.

And I will mention $cache->deleteItem('cache_key'); in the previous example (self-explained).

WDYT ?

mickaelandrieu · 2016-08-09T21:04:50Z

The docs is clear to me (non-native english).

Big thanks to you @nicolas-grekas ! I want to play with this component now ^^

tgalopin · 2016-08-10T08:28:43Z

components/cache/cache_invalidation.rst

+The Symfony Cache component provides three mechanisms to help solve this problem:
+
+* Tags based invalidation for managing data dependencies;
+* Namespace based invalidation for context dependend data;


nicolas-grekas · 2016-08-19T12:59:49Z

Comments addressed, examples updated. More comments welcomed :)

tgalopin · 2016-08-19T13:11:11Z

components/cache/cache_invalidation.rst

+``Vary: User-Agent`` or ``Vary: Accept-Encoding`` HTTP headers::
+
+    $perUserAgentCache = $httpCache->fork($varyingUserAgent);
+    $perAcceptEndoginPerUserAgentCache = $childCache->fork($varyingAcceptEncoding);


This PR was merged into the 3.2-dev branch. Discussion ---------- [Cache] Add PDO + Doctrine DBAL adapter | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#6858 This PR adds a PDO adapter for our PSR-6 cache items. The implementation heavily borrows from PdoSessionHandler. Commits ------- 82a0de2 [Cache] Add PDO + Doctrine DBAL adapter

This PR was merged into the 3.2-dev branch. Discussion ---------- [Cache] Add PDO + Doctrine DBAL adapter | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#6858 This PR adds a PDO adapter for our PSR-6 cache items. The implementation heavily borrows from PdoSessionHandler. Commits ------- 82a0de2 [Cache] Add PDO + Doctrine DBAL adapter

kbond · 2016-08-25T13:21:06Z

Maybe it is just me but I am not quite understanding the "Namespaces"/"Forkable" feature. Perhaps a more extensive example?

nicolas-grekas · 2016-09-02T08:54:26Z

@kbond see https://www.drupal.org/developing/api/8/cache/contexts for another use case of this feat. Maybe one should first read this page then help me find the right words to explain the feat. ? :)
This is hierarchical invalidation done from the outside, (the inside being prefixing keys explicitly e.g. ->getItem('foo/bar'))

fabpot · 2016-09-14T19:24:14Z

components/cache/cache_invalidation.rst

+* Expiration based invalidation for time related dependencies.
+
+.. versionadded:: 3.2
+    Tags and namespace based invalidation was introduced in Symfony 3.2.


were introduced

nicolas-grekas · 2016-09-15T16:58:36Z

I just rewrote entirely this paragraph, any better?

Koc · 2016-09-16T07:14:48Z

Much better now for me

kbond · 2016-09-16T12:49:03Z

I'm understanding it much better as well. The example is great!

nicolas-grekas · 2016-09-23T18:51:54Z

Closing, see symfony/symfony#19521 (comment)

…olas-grekas) This PR was merged into the master branch. Discussion ---------- [Cache] Add chapter about invalidation, tags, etc. This is a subpart of #6858 that tells only about merged features. Please merge asap so we can rebase #6858 on top and focus on its specific bits afterwards :) Commits ------- 0ffc261 [Cache] Add chapter about invalidation, tags, etc.

carsonbot added the Status: Needs Review label Aug 6, 2016

nicolas-grekas force-pushed the cache-invalidation branch 2 times, most recently from cd6020f to 95e7978 Compare August 7, 2016 08:20

wouterj reviewed Aug 7, 2016
View reviewed changes

nicolas-grekas force-pushed the cache-invalidation branch from 95e7978 to bb34f3c Compare August 7, 2016 09:38

wouterj reviewed Aug 7, 2016
View reviewed changes

carsonbot added Status: Needs Work and removed Status: Needs Review labels Aug 7, 2016

nicolas-grekas force-pushed the cache-invalidation branch 2 times, most recently from d30112d to f753506 Compare August 8, 2016 19:22

mickaelandrieu reviewed Aug 9, 2016
View reviewed changes

tgalopin reviewed Aug 10, 2016
View reviewed changes

nicolas-grekas force-pushed the cache-invalidation branch from f753506 to 7fa65ac Compare August 19, 2016 12:58

tgalopin reviewed Aug 19, 2016
View reviewed changes

nicolas-grekas force-pushed the cache-invalidation branch from 7fa65ac to e5e112f Compare August 19, 2016 13:22

nicolas-grekas mentioned this pull request Sep 2, 2016

[Cache] Add chapter about invalidation, tags, etc. #6947

Merged

nicolas-grekas force-pushed the cache-invalidation branch from e5e112f to 2c31a64 Compare September 2, 2016 09:32

carsonbot added Status: Needs Review and removed Status: Needs Work labels Sep 2, 2016

[Cache] Add chapter about invalidation, tags, etc.

0ffc261

nicolas-grekas force-pushed the cache-invalidation branch from 2c31a64 to 9f775bb Compare September 2, 2016 09:37

nicolas-grekas changed the title ~~[Cache] Add chapter about invalidation, tags, etc.~~ [Cache] Doc forkable adapters, aka namespace based invalidation Sep 2, 2016

fabpot reviewed Sep 14, 2016

View reviewed changes

[Cache] Doc context aware adapters, aka hierarchical invalidation

dd864d8

nicolas-grekas force-pushed the cache-invalidation branch from 9f775bb to dd864d8 Compare September 15, 2016 16:57

nicolas-grekas changed the title ~~[Cache] Doc forkable adapters, aka namespace based invalidation~~ [Cache] Doc context aware adapters, aka hierarchical invalidation Sep 16, 2016

nicolas-grekas closed this Sep 23, 2016

nicolas-grekas deleted the cache-invalidation branch September 23, 2016 18:51

javiereguiluz added the Cache label Jan 11, 2017

Uh oh!

[Cache] Doc context aware adapters, aka hierarchical invalidation #6858

[Cache] Doc context aware adapters, aka hierarchical invalidation #6858

Uh oh!

Conversation

nicolas-grekas commented Aug 6, 2016

Uh oh!

nicolas-grekas commented Aug 7, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wouterj Aug 7, 2016

Choose a reason for hiding this comment

Uh oh!

wouterj Aug 7, 2016

Choose a reason for hiding this comment

Uh oh!

wouterj commented Aug 7, 2016

Uh oh!

Koc commented Aug 7, 2016

Uh oh!

nicolas-grekas commented Aug 7, 2016

Uh oh!

mickaelandrieu Aug 9, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mickaelandrieu commented Aug 9, 2016

Uh oh!

tgalopin Aug 10, 2016

Choose a reason for hiding this comment

Uh oh!

nicolas-grekas commented Aug 19, 2016

Uh oh!

tgalopin Aug 19, 2016

Choose a reason for hiding this comment

Uh oh!

kbond commented Aug 25, 2016

Uh oh!

nicolas-grekas commented Sep 2, 2016

Uh oh!

fabpot Sep 14, 2016

Choose a reason for hiding this comment

Uh oh!

nicolas-grekas commented Sep 15, 2016

Uh oh!

Koc commented Sep 16, 2016

Uh oh!

kbond commented Sep 16, 2016

Uh oh!

nicolas-grekas commented Sep 23, 2016

Uh oh!

Uh oh!

nicolas-grekas commented Aug 7, 2016 •

edited

Loading

mickaelandrieu Aug 9, 2016 •

edited

Loading