Skip to content

[Bridge/PhpUnit] doc bin/simple-phpunit #6962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2016

Conversation

nicolas-grekas
Copy link
Member

fabpot added a commit to symfony/symfony that referenced this pull request Sep 12, 2016
…nit - yaml - prophecy) (nicolas-grekas)

This PR was merged into the 3.2-dev branch.

Discussion
----------

[Bridge/PhpUnit] Add bin/simple-phpunit wrapper (=phpunit - yaml - prophecy)

| Q             | A
| ------------- | ---
| Branch?       | master
| New feature?  | yes
| Tests pass?   | not yet
| License       | MIT
| Doc PR | symfony/symfony-docs#6962

So that e.g. [Sami](https://github.com/FriendsOfPHP/Sami/blob/master/phpunit) & [SensioFranmeworkExtraBundle](https://github.com/sensiolabs/SensioFrameworkExtraBundle/blob/master/phpunit) can stop copy/pasting our phpunit wrapper and get it from phpunit-bridge instead.

2 commits to keep the "rename" semantic in the git history.
Diff best viewed by looking directly at each commit.

Commits
-------

0c1c70c [Bridge/PhpUnit] Add bin/simple-phpunit wrapper (=phpunit - yaml - prophecy)
.. versionadded:: 3.2
The modified PHPUnit script script was introduced in Symfony 3.2.

This bridges provides a modified version of phpunit that you can call by using
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bridges -> This bridge

.. versionadded:: 3.2
The modified PHPUnit script script was introduced in Symfony 3.2.

This bridges provides a modified version of phpunit that you can call by using
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of phpunit that -> of PHPUnit that

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Status: reviewed

Thanks @nicolas-grekas!

configured by the ``SYMFONY_PHPUNIT_DIR`` env var, or in the same directory as
the ``simple-phpunit`` if it is not provided.

If you have installed the bridge through composer, you can run it by calling e.g.:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

composer -> Composer

@weaverryan
Copy link
Member

weaverryan commented Sep 15, 2016

Sweet! And I used the new PR edit feature to make the changes Javier suggested. YES!

@weaverryan weaverryan merged commit c600921 into symfony:master Sep 15, 2016
weaverryan added a commit that referenced this pull request Sep 15, 2016
…, weaverryan)

This PR was merged into the master branch.

Discussion
----------

[Bridge/PhpUnit] doc bin/simple-phpunit

See symfony/symfony#19915

Commits
-------

c600921 Making changes thanks to Javier!
46825ab [Bridge/PhpUnit] doc bin/simple-phpunit
@nicolas-grekas nicolas-grekas deleted the phpunit branch September 23, 2016 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants