[Ldap] Updated Ldap component documentation for 3.1 #6982
Conversation
|
Just for your own reference: Your answer there really helped me! |
|
|
||
| ``useStartTls`` | ||
| Whether or not to secure the connection using StartTLS | ||
| ``connection_string`` |
There was a problem hiding this comment.
Unrelated to this PR, but this option name looks weird. Is there a better alternative to connection_string ? For example, like dsn in the database world.
There was a problem hiding this comment.
Actually, the term "DSN" is specific to the database world. "connection_string" is standard for all software, and not only databases. :)
components/ldap.rst
Outdated
| ``useStartTls`` | ||
| Whether or not to secure the connection using StartTLS | ||
| ``connection_string`` | ||
| You may use this option instead of |
There was a problem hiding this comment.
This phrase looks unfinished: You may use this option instead of
There was a problem hiding this comment.
Indeed! Good catch!
There was a problem hiding this comment.
I'll change that soon (this week or the next, depending on whether I can find time to change this), and also add some information which came from my previous github comments (like @mipapo mentioned).
I'll
|
ping .. right now the 3.1 docs still talk about |
|
Unfortunately, I won't have time before the end of the week as I am pretty busy currently. Should be fine next week, though! :) |
as LdapClient has been marked deprecated in 3.1. Refs symfony/symfony#19008, symfony#6982
as LdapClient has been marked deprecated in 3.1. Refs symfony/symfony#19008, symfony#6982
as LdapClient has been marked deprecated in 3.1. Refs symfony/symfony#19008, symfony#6982
|
The doc is still outdated ? I have tested with the Ldad class (+factory) and it works well. |
|
Yes, there are a few things still pending to get this PR merged. Unfortunately I am too busy to finalise this in the short term, but if someone wants, he can make a small PR against my fork, or create a new PR based on this one. |
|
This has been finally merged! Thanks for contributing these docs. |
…razi, javiereguiluz) This PR was submitted for the 3.1 branch but it was merged into the 3.3 branch instead (closes #6982). Discussion ---------- [Ldap] Updated Ldap component documentation for 3.1 | Q | A | | --- | --- | | Doc fix? | no | | New docs? | yes | | Applies to | 3.1, 3.2 | | Fixed tickets | #5756 | Unfortunately, I didn't have the time to update the docs since I have been pretty busy these last months, but like people say, better late than never! The documentation has been updated for version 3.1 of the Ldap component, which no longer uses the same class, and now provides an LdapManager which can create new LDAP entries, or manipulate existing ones (update or delete). I didn't add a documentation section regarding the legacy classes, but I figure that they should no longer be described as the main entry points for the Ldap component. Commits ------- 066f5be Minor fixes 78ed43d Updated LDAP documentation for Symfony 3.1
|
Woohoo! Thanks @javiereguiluz! |
Unfortunately, I didn't have the time to update the docs since I have been pretty busy these last months, but like people say, better late than never!
The documentation has been updated for version 3.1 of the Ldap component, which no longer uses the same class, and now provides an LdapManager which can create new LDAP entries, or manipulate existing ones (update or delete).
I didn't add a documentation section regarding the legacy classes, but I figure that they should no longer be described as the main entry points for the Ldap component.