Add documentation about access denied handler #7105

nykopol · 2016-10-31T19:50:47Z

ogizanagi · 2016-11-01T10:54:30Z

security/access_denied_handler.rst

+        custom_handler.service.id:
+            class: AppBundle\Security\AccessDeniedHandler
+
+That's it, now on the ``foo`` firewall, all ``AccessDeniedException`` will be notified to you service.


- to you service. + to your service.

xabbuh · 2016-11-02T21:17:15Z

security/access_denied_handler.rst

+How to Create a Custom Access Denied Handler
+============================================
+
+When your application throw an ``AccessDeniedException`` you can catch this exception


missing comma before "you"

xabbuh · 2016-11-02T21:18:21Z

security/access_denied_handler.rst

+                    'access_denied_handler' => 'custom_handler.service.id',
+                ),
+            ),
+        ));


Can you please also add an XML config example?

xabbuh · 2016-11-02T21:18:34Z

security/access_denied_handler.rst

+        ));
+
+
+Your handler must implement the interface


we can omit "interface" here

xabbuh · 2016-11-02T21:18:40Z

security/access_denied_handler.rst

+
+Your handler must implement the interface
+:class:`Symfony\\Component\\Security\\Http\\Authorization\\AccessDeniedHandlerInterface`.
+This interface define one method called ``handle()`` that can do whatever you want.


I would reword this a bit:

[...] that implements the logic you want to execute when access is denied to the current user.

xabbuh · 2016-11-02T21:19:43Z

security/access_denied_handler.rst

+Your handler must implement the interface
+:class:`Symfony\\Component\\Security\\Http\\Authorization\\AccessDeniedHandlerInterface`.
+This interface define one method called ``handle()`` that can do whatever you want.
+You can use it to send a mail, log a message, or generally return a custom Response.


This could then be enclosed with parentheses after the previous sentence.

xabbuh · 2016-11-02T21:19:54Z

security/access_denied_handler.rst

+This interface define one method called ``handle()`` that can do whatever you want.
+You can use it to send a mail, log a message, or generally return a custom Response.
+
+


Please remove one blank line.

xabbuh · 2016-11-02T21:20:27Z

security/access_denied_handler.rst

+
+.. code-block:: php
+
+    namespace AppBundle\Security;


We should better not use AppBundle in this context.

What would be a good place for this class ? For me AppBundle\Security look like a perfect default place for a Foo project.

Ah sorry, I was confused. Of course let's keep it as is.

xabbuh · 2016-11-02T21:20:43Z

security/access_denied_handler.rst

+    use Symfony\Component\Security\Http\Authorization\AccessDeniedHandlerInterface;
+    use Symfony\Component\HttpFoundation\Request;
+    use Symfony\Component\HttpFoundation\Response;
+    use Symfony\Component\Security\Core\Exception\AccessDeniedException;


Can you please sort the use statements alphabetically?

nykopol · 2016-11-03T04:16:46Z

@xabbuh thanks for your review.

…ch is a Symfony class)

javiereguiluz

👍 another missing feature documented! Thanks a lot @nykopol.

I've made some minor rewords in your original article. If you don't agree with something, please tell us. Thanks!

nykopol · 2016-11-21T09:52:01Z

@javiereguiluz LGTM, thanks

… javiereguiluz) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #7105). Discussion ---------- Add documentation about access denied handler Fix #5139 Commits ------- ea4b7f8 Minor rewordings dff303c When talking about generic responses, don't spell it as Response (which is a Symfony class) a9f815a xabbuh review 66c0e76 fix typo db65dd8 fix yml marker to yaml a17965e add documentation about access denied handler

xabbuh · 2016-11-28T21:16:01Z

Thank you @nykopol for your great work on this PR. I have merged your changes and made some minor tweaks in c698051.

* 2.7: (31 commits) fix a typo [#7115] fix headlines Better explain the most common problems when testing emails Clarify the mappings that require no method prefix. Make some long lines shorter to fit our soft limit of 80 chars per line Microsoft Azure update step by step article and screenshots for the new Microsoft Azure Portal Minor rewords in the text and the code example Update questionhelper.rst Add docs about console question answer normalizing. [#7105] add XML and PHP service config examples Minor rewordings When talking about generic responses, don't spell it as Response (which is a Symfony class) xabbuh review fix typo fix yml marker to yaml add documentation about access denied handler Update outdated link to AWS ELB security groups Added missing comma Reworded the caution about open redirects Warn user about open redirects ...

* 2.8: (37 commits) fix a typo [#7115] fix headlines Better explain the most common problems when testing emails Clarify the mappings that require no method prefix. Make some long lines shorter to fit our soft limit of 80 chars per line Microsoft Azure update step by step article and screenshots for the new Microsoft Azure Portal Minor rewords in the text and the code example Update questionhelper.rst Add docs about console question answer normalizing. [#7105] add XML and PHP service config examples Minor rewordings When talking about generic responses, don't spell it as Response (which is a Symfony class) xabbuh review fix typo fix yml marker to yaml add documentation about access denied handler Update outdated link to AWS ELB security groups Added missing comma Reworded the caution about open redirects Warn user about open redirects ...

* 3.1: (41 commits) fix a typo [#7115] fix headlines Better explain the most common problems when testing emails Clarify the mappings that require no method prefix. Make some long lines shorter to fit our soft limit of 80 chars per line Microsoft Azure update step by step article and screenshots for the new Microsoft Azure Portal Minor rewords in the text and the code example Update questionhelper.rst Add docs about console question answer normalizing. [#7105] add XML and PHP service config examples Minor rewordings When talking about generic responses, don't spell it as Response (which is a Symfony class) xabbuh review fix typo fix yml marker to yaml add documentation about access denied handler Update outdated link to AWS ELB security groups Added missing comma Reworded the caution about open redirects Warn user about open redirects ...

add documentation about access denied handler

10eff85

carsonbot added the Status: Needs Review label Oct 31, 2016

fix yml marker to yaml

3d28e5b

ogizanagi reviewed Nov 1, 2016

View reviewed changes

fix typo

4731340

xabbuh reviewed Nov 2, 2016

View reviewed changes

security/access_denied_handler.rst

));

Your handler must implement the interface

Copy link

Member

xabbuh Nov 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can omit "interface" here

xabbuh reviewed Nov 2, 2016

View reviewed changes

xabbuh review

e8b708b

javiereguiluz added 2 commits November 21, 2016 10:22

When talking about generic responses, don't spell it as Response (whi…

7922dc9

…ch is a Symfony class)

Minor rewordings

b30ad2a

javiereguiluz approved these changes Nov 21, 2016

View reviewed changes

javiereguiluz added Status: Reviewed and removed Status: Needs Review labels Nov 21, 2016

xabbuh added a commit that referenced this pull request Nov 28, 2016

[#7105] add XML and PHP service config examples

c698051

xabbuh closed this Nov 28, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add documentation about access denied handler #7105

Add documentation about access denied handler #7105

nykopol commented Oct 31, 2016

ogizanagi Nov 1, 2016

xabbuh Nov 2, 2016

xabbuh Nov 2, 2016

xabbuh Nov 2, 2016

xabbuh Nov 2, 2016

xabbuh Nov 2, 2016

xabbuh Nov 2, 2016

xabbuh Nov 2, 2016

xabbuh Nov 2, 2016

xabbuh Nov 2, 2016

nykopol Nov 3, 2016

xabbuh Nov 4, 2016

xabbuh Nov 2, 2016

nykopol commented Nov 3, 2016

javiereguiluz left a comment

nykopol commented Nov 21, 2016

xabbuh commented Nov 28, 2016

		This interface define one method called ``handle()`` that can do whatever you want.
		You can use it to send a mail, log a message, or generally return a custom Response.

Add documentation about access denied handler #7105

Add documentation about access denied handler #7105

Conversation

nykopol commented Oct 31, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nykopol commented Nov 3, 2016

javiereguiluz left a comment

Choose a reason for hiding this comment

nykopol commented Nov 21, 2016

xabbuh commented Nov 28, 2016