Skip to content

fixed app/console #7106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 63 commits into from
Closed

fixed app/console #7106

wants to merge 63 commits into from

Conversation

andreybolonin
Copy link
Contributor

No description provided.

chalasr and others added 30 commits June 23, 2016 20:46
Fix missing colon

Change userInputs to inputs

Try to fix platformsh build

Re-add useful use statements

Fixed typo, use FQCN::method

Rollback not useful diff

Formatting

Add more examples, precise documentation

typo 'would have type' => 'would have typed'

removing an ending dot in comment for consistency
…ing user inputs (chalasr)

This PR was merged into the master branch.

Discussion
----------

[Console] Adapt doc for easier testing of commands needing user inputs

Doc-PR for symfony/symfony#18710.

This one eases testing of commands needing user interactions by simulating them from the CommandTester directly, by creating a input stream from the ones set by the developer.

Commits
-------

26fdbe0 [Console] Adapt doc for easier testing of commands needing user inputs
* 3.1:
  [#6597] some tweaks
  [Validator] Add shorter examples using the default option
  Typo fix
  Added the documentation for the Cache component
  Add missing parameter
  Updated the CS rule about return null; and return;
  [#6690] fix syntax error
  Update date.rst - Fixes typo
  [#6690] add versionadded directive
  Added an example for a different method of verbosity level usage.
  NullOutput should be passed to $command->run()
  Hard values for the driver option
  Fix ldap security examples
This PR was merged into the master branch.

Discussion
----------

Routes should be just imported, not mounted

Finishes #6612

Commits
-------

34a3166 Routes should be just imported, not mounted
This PR was squashed before being merged into the master branch (closes #6737).

Discussion
----------

Document the file() controller helper

This rewords #6732 to document the new feature with less words and more code.

Commits
-------

be5e951 Document the file() controller helper
* 3.1: (47 commits)
  Removing old :term: stuff
  Replacing missing link
  Fixing typo
  Final changes
  [WIP] More changes
  [WIP] More changes
  [WIP] Removing multiple formats - it makes no sense here
  [WIP] More changes
  [WIP] Reading through the changes
  changes according to comments after PR + some other typos
  typo fix in hyperlink
  typo fix in hyperlink
  colon  corrections
  made some new changes, corrected mistakes, undo some foolish deletions
  [] changes in the first four ch of the book
  [Form] Ambiguous block prefixes render incorrectly
  Removing old :term: stuff
  Replacing missing link
  Fixing typo
  Final changes
  ...
$controller always return false. 

$controller = $controllerResolver->getController($request);
$arguments = $argumentResolver->getArguments($request, $controller);
The two lines above should run after:
$request->attributes->add($matcher->match($request->getPathInfo()));
* 3.1: (35 commits)
  [KnpU] Making common 3.0 changes (e.g. app/console -> bin/console)
  using shorter command name
  fixing app/console
  Fixing heading styles that I just messed up!
  Minor tweaks!
  Tweaks!
  Fixed some misconfigured redirections
  Tweaks thanks to comments
  minor tweaks
  Completely updating the configuration main chapter to talk about parameters and a few other details
  more tweaks
  Moving configuration/configuration.rst -> configuration.rst
  Tweaks thanks to Javier
  Updating and massively shortening page creation
  Moving http_fundamentals into introduction
  Moving web server configuration out of configuration - it has nothing to do with Symfony configuration
  Fixing references
  Moving logging/monolog.rst to /logging.rst, removing some sections from it, rewriting others
  Another batch of build error fixes
  language tweak
  ...
This PR was merged into the master branch.

Discussion
----------

bootstrapping Workflow component docs

Commits
-------

84ac92d bootstrapping workflow docs
weaverryan and others added 9 commits August 20, 2016 19:56
* 3.1: (21 commits)
  Adding details about the Symfony framework as comments
  Adjust Application use statement
  replacing with index, otherwise these documents are not included in *any* index
  Update Reference to Service Container Tags
  Update PropertyAccess Component Path
  Fix Incorrect Indent
  Suggested Changes
  Add PropertyInfo Component Documentation
  Removed the "Learn more" section
  Created a "Platform as a Service" section
  Minor improvements
  Fixed the "make" command
  Fixed again the tricky list syntax
  Fixed the syntax of the list
  Minor fixes
  Reword the third step
  Added the missing link references
  Updated the instructions to build docs locally
  Refactore how to get the container in a test
  Fixed a reference
  ...
* 3.1:
  Update custom_provider.rst
  [#6892] The provider is called `memory`
  Fix typos
  Update templating.rst
  Update templating.rst
  Adds bin folder creation instruction
  Update http_kernel_controller_resolver.rst
  Fix typos
  service_container : fix php Definition instance
  [Routing] Fix a route path in a routing example
  Minor unrelated spacing fixes
  Update doctrine.rst
…, weaverryan)

This PR was merged into the master branch.

Discussion
----------

[Bridge/PhpUnit] doc bin/simple-phpunit

See symfony/symfony#19915

Commits
-------

c600921 Making changes thanks to Javier!
46825ab [Bridge/PhpUnit] doc bin/simple-phpunit
This PR was merged into the master branch.

Discussion
----------

[Config] Add ExprBuilder::ifEmpty()

After symfony/symfony#19764

Commits
-------

f0fe739 [WCM][Config] Add ExprBuilder::ifEmpty()
@wouterj
Copy link
Member

wouterj commented Nov 1, 2016

👍
status: reviewed

Thanks! This will be merged into 3.1, as that's the oldest 3.x branch that we still support. If you want to take the challenge, please rebase your branch and change the target branch of this PR by editing it. Otherwise, we'll just do it with our handy merge tool!

@javiereguiluz
Copy link
Member

👍

@andreybolonin andreybolonin changed the base branch from master to 3.1 November 2, 2016 09:10
@andreybolonin
Copy link
Contributor Author

andreybolonin commented Nov 2, 2016

Wrong rebase. Sorry.
#7109
3.1 -> 3.1
Close this PR?

xabbuh added a commit that referenced this pull request Nov 5, 2016
…onin)

This PR was merged into the 3.1 branch.

Discussion
----------

fixed app/console to bin/console on 3.1 branch

Instead of #7106.
From 3.1 fork to 3.1 branch.

Commits
-------

cfaaf08 Update input.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.