-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Explained how to improve the readability of long numeric literals #7196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Dec 8, 2016
@@ -203,6 +203,25 @@ changed using the third argument as follows:: | |||
foo: bar | |||
bar: baz | |||
|
|||
Numeric literals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Numeric Literals
👍 Status: Reviewed |
@javiereguiluz We need a |
Thank you Javier. |
xabbuh
added a commit
that referenced
this pull request
Dec 14, 2016
…c literals (javiereguiluz) This PR was squashed before being merged into the 3.2 branch (closes #7196). Discussion ---------- Explained how to improve the readability of long numeric literals This fixes #7183. Commits ------- 494a9ae Explained how to improve the readability of long numeric literals
xabbuh
added a commit
that referenced
this pull request
Dec 14, 2016
xabbuh
added a commit
that referenced
this pull request
Dec 14, 2016
* 3.2: (22 commits) add missing config formats [#7224] fix indentation [#7220] some minor tweaks [#7196] add versionadded directive Explained how to improve the readability of long numeric literals Fix typo in workflow usage code lock Added "How to Use a Custom Version Strategy for Assets" Use PHP 5.5's ::class notation Update state-machines.rst [PHPUnitBridge] Fix copy/paste error [PHPUnitBridge] Fix copy/paste error [#7243] minor tweak Deletes duplicate "Deprecated" and adds a more explicit example. Accepted Suggestions Update 'query_builder' option Mentioned %env(...)% variables in Best Practices book Accepted suggestions in the guard documentation Accepted suggestions in the guard documentation Accepted suggestions in the guard documentation Update guard_authentication.rst ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7183.