Skip to content

Explained how to improve the readability of long numeric literals #7196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

javiereguiluz
Copy link
Member

This fixes #7183.

@@ -203,6 +203,25 @@ changed using the third argument as follows::
foo: bar
bar: baz

Numeric literals
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Numeric Literals

@xabbuh
Copy link
Member

xabbuh commented Dec 8, 2016

👍

Status: Reviewed

@xabbuh
Copy link
Member

xabbuh commented Dec 12, 2016

@javiereguiluz We need a versionadded directive for this.

@xabbuh
Copy link
Member

xabbuh commented Dec 14, 2016

Thank you Javier.

xabbuh added a commit that referenced this pull request Dec 14, 2016
…c literals (javiereguiluz)

This PR was squashed before being merged into the 3.2 branch (closes #7196).

Discussion
----------

Explained how to improve the readability of long numeric literals

This fixes #7183.

Commits
-------

494a9ae Explained how to improve the readability of long numeric literals
xabbuh added a commit that referenced this pull request Dec 14, 2016
@xabbuh xabbuh closed this Dec 14, 2016
xabbuh added a commit that referenced this pull request Dec 14, 2016
* 3.2: (22 commits)
  add missing config formats
  [#7224] fix indentation
  [#7220] some minor tweaks
  [#7196] add versionadded directive
  Explained how to improve the readability of long numeric literals
  Fix typo in workflow usage code lock
  Added "How to Use a Custom Version Strategy for Assets"
  Use PHP 5.5's ::class notation
  Update state-machines.rst
  [PHPUnitBridge] Fix copy/paste error
  [PHPUnitBridge] Fix copy/paste error
  [#7243] minor tweak
  Deletes duplicate "Deprecated" and adds a more explicit example.
  Accepted Suggestions
  Update 'query_builder' option
  Mentioned %env(...)% variables in Best Practices book
  Accepted suggestions in the guard documentation
  Accepted suggestions in the guard documentation
  Accepted suggestions in the guard documentation
  Update guard_authentication.rst
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants