Update 'query_builder' option #7220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks @phrix32! 👍 Status: Reviewed |
|
@phrix32 When changing the base branch, you have to rebase your changes. Are you able to do that? Can we help you with it? |
|
Oh sorry, I forgot that. I'm not sure if I rebased correctly now. Can you please check @xabbuh? |
xabbuh
reviewed
Dec 9, 2016
| @@ -191,6 +191,13 @@ The value of this option can either be a ``QueryBuilder`` object, a Closure or | |||
| passed the ``EntityRepository`` of the entity as the only argument and should | |||
| return a ``QueryBuilder``. | |||
|
|
|||
| .. caution:: | |||
|
|
|||
| The entity used in ``FROM`` clause of `query_builder`_ option | |||
| .. caution:: | ||
|
|
||
| The entity used in ``FROM`` clause of `query_builder`_ option | ||
| will always be validated against the class which you have specified in form field option `class`_. |
There was a problem hiding this comment.
[...] which you have specified with the form's class option.
| The entity used in ``FROM`` clause of `query_builder`_ option | ||
| will always be validated against the class which you have specified in form field option `class`_. | ||
| If you return another entity instead of the one used in your ``FROM`` clause, | ||
| for instance ``SELECT`` an entity from a joined table, it will break validation. |
There was a problem hiding this comment.
(for instance if you return an entity from a joined table)
The entity used in 'FROM' clause of 'query_builder' option will always be validated against the class which you have specified in form field option 'class'. If you return another entity instead of the one used in your FROM clause, for instance SELECT an entity from a joined table, it will break validation.
|
Hey @xabbuh I adapted the documentation like you suggested. |
|
Thank you @phrix32. |
xabbuh
added a commit
that referenced
this pull request
Dec 14, 2016
This PR was merged into the 2.7 branch. Discussion ---------- Update 'query_builder' option The entity used in 'FROM' clause of 'query_builder' option will always be validated against the class which you have specified in form field option 'class'. If you return another entity instead of the one used in your FROM clause, for instance SELECT an entity from a joined table, it will break validation. Closes #4331 Commits ------- bab634b Update 'query_builder' option
xabbuh
added a commit
that referenced
this pull request
Dec 14, 2016
xabbuh
added a commit
that referenced
this pull request
Dec 14, 2016
* 2.7: [#7220] some minor tweaks Update 'query_builder' option
xabbuh
added a commit
that referenced
this pull request
Dec 14, 2016
* 2.8: [#7220] some minor tweaks Use PHP 5.5's ::class notation [#7243] minor tweak Deletes duplicate "Deprecated" and adds a more explicit example. Accepted Suggestions Update 'query_builder' option Accepted suggestions in the guard documentation Accepted suggestions in the guard documentation Accepted suggestions in the guard documentation Update guard_authentication.rst Use PHP 5.5's ::class notation
xabbuh
added a commit
that referenced
this pull request
Dec 14, 2016
* 3.1: [#7220] some minor tweaks Added "How to Use a Custom Version Strategy for Assets" Use PHP 5.5's ::class notation [#7243] minor tweak Deletes duplicate "Deprecated" and adds a more explicit example. Accepted Suggestions Update 'query_builder' option Accepted suggestions in the guard documentation Accepted suggestions in the guard documentation Accepted suggestions in the guard documentation Update guard_authentication.rst Use PHP 5.5's ::class notation
xabbuh
added a commit
that referenced
this pull request
Dec 14, 2016
* 3.2: (22 commits) add missing config formats [#7224] fix indentation [#7220] some minor tweaks [#7196] add versionadded directive Explained how to improve the readability of long numeric literals Fix typo in workflow usage code lock Added "How to Use a Custom Version Strategy for Assets" Use PHP 5.5's ::class notation Update state-machines.rst [PHPUnitBridge] Fix copy/paste error [PHPUnitBridge] Fix copy/paste error [#7243] minor tweak Deletes duplicate "Deprecated" and adds a more explicit example. Accepted Suggestions Update 'query_builder' option Mentioned %env(...)% variables in Best Practices book Accepted suggestions in the guard documentation Accepted suggestions in the guard documentation Accepted suggestions in the guard documentation Update guard_authentication.rst ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The entity used in 'FROM' clause of 'query_builder' option will always be validated against the class which you have specified in form field option 'class'. If you return another entity instead of the one used in your FROM clause, for instance SELECT an entity from a joined table, it will break validation.
Closes #4331