Covering two missing Cache adapters introduced in 3.2 #7424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Jan 28, 2017
| @@ -58,6 +58,25 @@ contents as regular files in a set of directories on the local file system:: | |||
| $directory = null | |||
| ); | |||
|
|
|||
| Php Files Cache Adapter | |||
There was a problem hiding this comment.
Php Files -> PHP Files ? (after all, PHP is an acronym)
There was a problem hiding this comment.
I'm going to leave this - I did it because the name of the class is PhpFilesAdapter... but I could see it either way (I would normally 100% agree)
| ~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| This adapter is very similar to the Filesystem adapter, except that the saving creates | ||
| a ``.php`` file, which is included on fetch (allowing the file to me saved in OpCache):: |
| @@ -189,6 +208,41 @@ This adapter also defines two optional arguments called ``namespace`` (default: | |||
| ``''``) and ``defaultLifetime`` (default: ``0``) and adapts them to make them | |||
| work in the underlying Doctrine cache. | |||
|
|
|||
| Php Array Cache Adapter | |||
| ~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| This adapter is a highly performant way to cache static data (e.g. application configuration) | ||
| that is optimized and preloaded into OpCache memory storage:: |
There was a problem hiding this comment.
OpCache -> OPcache (according to http://php.net/manual/en/book.opcache.php)
| use Symfony\Component\Cache\Adapter\PhpArrayAdapter; | ||
| use Symfony\Component\Cache\Adapter\PhpFilesAdapter; | ||
|
|
||
| // somehow, decide it's time to warmup the cache! |
weaverryan
added a commit
that referenced
this pull request
Jan 28, 2017
…weaverryan) This PR was merged into the 3.2 branch. Discussion ---------- Covering two missing Cache adapters introduced in 3.2 Hi guys! These are 2 missing adapters that were introduced in 3.2! symfony/symfony#18894 and symfony/symfony#18823 Cheers! Commits ------- a3e69e2 Tweaks based on feedback! 1b6cb69 Covering two missing adapters introduced in 3.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
These are 2 missing adapters that were introduced in 3.2! symfony/symfony#18894 and symfony/symfony#18823
Cheers!