Add xml files #7857
Merged
Add xml files #7857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have an idea why platformsh fails? |
|
Thank you! Sometimes platform.sh just does that... but it's also a little uncommon to have a PR for a PR... so maybe that was it :) |
|
That's a tangible explanation... :) |
weaverryan
added a commit
that referenced
this pull request
May 5, 2017
This PR was merged into the master branch. Discussion ---------- Updates to DI config for 3.3 Hi guys! WIP changes the new DI changes in 3.3! Woohoo! Some notes for myself: This relates to, oh, just these 10+ issues :). Assume they will all be closed by this one PR - before merge, if any of them aren't covered, I'll remove them. TODOS later (some might already be done) - update to use `debug:container --types` (symfony/symfony#22624) - update all other documents for possible changes for autowiring and autoconfigure - new page for existing Symfony users to explain the changes - update autowire section to talk about using aliases - document instanceof and also the ability to add configuration to the PSR4 loader - some links in the controller go to the API docs of `Controller`. But this is wrong, the methods now live in `ControllerTrait`... but the API docs for traits is basically broken: http://api.symfony.com/master/Symfony/Bundle/FrameworkBundle/Controller/ControllerTrait.html - how should we pass a parameter to a controller? - do Twig extensions still need to be public? If so, the example in `service_container` about autoconfigure is still not quite right Definitely included in this PR * #7544 * #7482 * #7339 * #7672 Not included in this PR (but related to DI changes) * #7329 * #7782 * #7777 * #7706 * #7608 * #7538 * #7441 * #7255 * ~~#7041~~ * ~~#7445~~ * ~~#7444~~ * ~~#7436~~ Commits ------- 22adfbd removing duplicate target 12c4944 Tweaks after amazing review from @GuilhemN and @xabbuh cac3c6c Merge remote-tracking branch 'origin/master' into di-3.3-changes 2229fd3 Merge remote-tracking branch 'origin/master' into di-3.3-changes 5452c61 Adding section about public: false ee27765 Adding versionadded bc7088d Merge remote-tracking branch 'origin/di-3.3-changes' into di-3.3-changes 443aec2 Merge pull request #7857 from GuilhemN/patch-1 89e12de bad link 6de83e2 fixing build problem 759e9b2 last tweaks from feedback 45500b3 Adding details and usages of fetching the service as a controller arg 70178d1 adding note about autoconfigure 6e6ed94 more tweaks 0e48bd8 [WIP] Updates to DI config for 3.3 9ab27f0 Add xml files 2636bea bad link c45daf4 fixing build problem 9e84572 last tweaks from feedback 049df7d Adding details and usages of fetching the service as a controller arg 105801c adding note about autoconfigure 2d11347 more tweaks 8433fc1 [WIP] Updates to DI config for 3.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix of some of my comments in #7807
ping @weaverryan