correct PHP code #8013
Closed
correct PHP code #8013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfelbox
reviewed
Jun 9, 2017
form/unit_testing.rst
Outdated
| /** | ||
| * @dataProvider getValidTestData | ||
| */ | ||
|
|
There was a problem hiding this comment.
This change looks wrong, as the data provider for the method testForm is the method getValidTestData.
The PHP doc
/**
* @dataProvider getValidTestData
*/doesn't mean
this method is a data provider
but instead means
the data provider for this method is this other method
There was a problem hiding this comment.
There was a problem hiding this comment.
Indeed, this part needs to be kept as is. But the other change is great. 👍
Closed
xabbuh
approved these changes
Jun 13, 2017
|
Thank you @MedUnes. |
xabbuh
added a commit
that referenced
this pull request
Jun 18, 2017
xabbuh
added a commit
that referenced
this pull request
Jun 18, 2017
xabbuh
added a commit
that referenced
this pull request
Jun 18, 2017
* 2.8: [#8013] revert wrong data provider change correct PHP code Added a missing <script> tag in an example minor tweak Fix comment to be consistent with the example Reworded the article about slashes in routing placeholders Minor reword of code contribution standards
xabbuh
added a commit
that referenced
this pull request
Jun 18, 2017
* 3.2: [#8048] some minor tweaks [#8013] revert wrong data provider change correct PHP code Added a missing <script> tag in an example clarify workflow events minor tweak Fix comment to be consistent with the example Reworded the article about slashes in routing placeholders Minor reword of code contribution standards
xabbuh
added a commit
that referenced
this pull request
Jun 18, 2017
* 3.4: [#8048] some minor tweaks [#8013] revert wrong data provider change correct PHP code Added a missing <script> tag in an example Fix variable name in CSFR token example code [AUTOWIRE] Fix invalid yaml code clarify workflow events minor tweak Fix comment to be consistent with the example fix invalid code lines and remove extra space Reworded the article about slashes in routing placeholders Minor reword of code contribution standards
weaverryan
added a commit
that referenced
this pull request
Jun 28, 2017
* origin/2.8: [#8013] revert wrong data provider change correct PHP code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.