Fixing wrong variable #8015
Closed
Fixing wrong variable #8015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be `$validator` instead of `$this->validator`
weaverryan
reviewed
Jun 13, 2017
| // $this->validator = $this->getMock(ValidatorInterface::class); | ||
| $this->validator | ||
| // $validator = $this->getMock(ValidatorInterface::class); | ||
| $validator | ||
| ->method('validate') | ||
| ->will($this->returnValue(new ConstraintViolationList())); | ||
| $validator |
There was a problem hiding this comment.
It might be better to change the other spots back to how they were before, and fix this line to be $this->validator. They are definitely inconsistent (and should be fixed), but there is some value on setting it on a property (your tests can further configure the $this->validator mock.
There was a problem hiding this comment.
Indeed, luckily we already have a pull request suggesting exactly this change (see #8013). So this will be fixed soon. That's why I'm gonna close here. But thank you for making us aware of this issue @hthtung90. Looking forward to see you soon again with some other changes. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be
$validatorinstead of$this->validator