Removing warning about bind + controller + scalar values #9477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweet! To avoid confusion for readers that may be using 4.0 but reading 4.1 docs, what about adding this: .. versionadded:: 4.1
The feature to bind scalar values to controller arguments was introduced in
Symfony 4.1. Previously you could only autowire services. |
|
You're totally right! I added the note. |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Mar 25, 2018
…uments (weaverryan) This PR was merged into the 4.1-dev branch. Discussion ---------- Adding support to bind scalar values to controller arguments | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25960 | License | MIT | Doc PR | symfony/symfony-docs#9477 Hi guys! This fixes (I think) the last rough edge with autowiring & error messages. 100% credit to @nicolas-grekas for this implementation - he has generously allowed me to steal his code in return for writing the test. I did test this on a real project. Cheers! Commits ------- 2c7198c Adding support to bind scalar values to controller arguments
weaverryan
added a commit
that referenced
this pull request
Mar 25, 2018
…s (weaverryan) This PR was squashed before being merged into the master branch (closes #9477). Discussion ---------- Removing warning about bind + controller + scalar values Docs for symfony/symfony#26658 :) Commits ------- af00dbc adding version note about scalar bind args 4312518 Removing warning about bind + controller + scalar values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs for symfony/symfony#26658 :)