This repository was archived by the owner on Nov 27, 2020. It is now read-only.
Don't log console errors in console output #1044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great catch @chalasr :) thanks |
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Feb 1, 2017
This PR was merged into the 3.3-dev branch. Discussion ---------- Don't log console errors in console output Since symfony/symfony#21003, console errors are logged, and since the `console` channel is not ignored by the monolog console handler, the log is written to stderr. IMHO it's useless since the ran command already write the message into, it's just having two traces for the same error, which doesn't make sense to me. I propose to fix that. __Before__  __After__  If one wants the trace, then one can run the command in verbose mode or look at its log file. Commits ------- 2bf1249 Don't log console errors in console output
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since symfony/symfony#21003, console errors are logged, and since the
consolechannel is not ignored by the monolog console handler, the log is written to stderr.IMHO it's useless since the ran command already write the message into, it's just having two traces for the same error, which doesn't make sense to me.
I propose to fix that.
Before
After
If one wants the trace, then one can run the command in verbose mode or look at its log file.