Skip to content
This repository was archived by the owner on Nov 27, 2020. It is now read-only.

removed non-MIT/BSD licensed bundles (closes #442) #535

Merged
merged 1 commit into from
Apr 30, 2013
Merged

removed non-MIT/BSD licensed bundles (closes #442) #535

merged 1 commit into from
Apr 30, 2013

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Apr 26, 2013

In #442, there is a discussion about the license of librairies and bundles included in the Symfony Standard Edition.

This pull requests removes all non-MIT/BSDlicensed code from Symfony SE. The impact is not that big and adding back those bundles is relatively easy.

Any thoughts before I merge?

@lsmith77
Copy link
Contributor

+1

@Taluu
Copy link

Taluu commented Apr 26, 2013

👍

capabilities

* **AcmeDemoBundle** (in dev/test env) - A demo bundle with some example
code

All libraries and bundles included in the Symfony Standard Edition are
released under the MIT, BSD, or LGPL license.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still have LGPL code ? Doctrine is not using LGPL anymore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swiftmailer is LGPL and sql-formatter too.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm asking jdorn to clarify which LGPL license he actually uses. It is not specified properly in the composer.json.

See: jdorn/sql-formatter#38

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrobeson It is specified clearly in the code files

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for the record, I talked with Chris (the creator of Swiftmailer) some time ago about switching the license of Swiftmailer from LGPL to MIT and he approved. I've just sent the email to all other committers to get their approvals as well. So, let's cross our fingers, and hopefully, Swiftmailer won't be a problem anymore soon.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want to do the license change a bit more formal you can use @beberlei's license manager

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer that people actually answer with an email, rather than clicking on an ephemeral website.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can change sql formatte rto be an optional dependency if its a problem, the formatting is not really an important feature.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem beberlei. looks like jdorn will change it.

@peterrehm
Copy link
Contributor

👍 - But is there any comment from @schmittjoh?

@@ -59,7 +58,6 @@ public function helloAction($name)

/**
* @Route("/hello/admin/{name}", name="_demo_secured_hello_admin")
* @Secure(roles="ROLE_ADMIN")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should still secure it in another way, otherwise it will not demo the secured area

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see security.yml

@ghost
Copy link

ghost commented Apr 26, 2013

adding back the bundles is easy, but shouldn't a note be left to mention why this was done? and to point people where to the bundles? Something like this:

NOTE: The Standard Edition previously contained bundles that were licensed under the Apache 2.0 license. 
LIST BUNDLES AND LINKS HERE
 These bundles were removed due to incompatibility with the popular (L)GPL 2 licenses. If you do not require
any libraries that are licensed under (L)GPL 2 then you are free to install them.

@guillaumepotier
Copy link

👍

@ghost
Copy link

ghost commented Apr 26, 2013

If @jdorn chooses lgpl 3 for sql-formatter then we run into another gpl 2 incompatibility with the profilerbundle. If he chooses lgpl 2 it will be incompatible with swiftmailer

@fabpot
Copy link
Member Author

fabpot commented Apr 26, 2013

What's the problem with the ProfilerBundle?

@jdorn
Copy link

jdorn commented Apr 26, 2013

I don't mind changing SqlFormatter to MIT. Will that fix any issues? I knew absolutely nothing about licenses when I first picked one to go with.

Do I need to include a LICENSE.txt file or something in the project in addition to stating it in composer.json?

@Crell
Copy link

Crell commented Apr 26, 2013

Generally it's wise to include a license.txt file as a lowest common denominator.

I'm out of town at the moment but I'd be happy to chat with you next week in irc if you want. I used to be the Drupal Association director of legal affairs so I have some experience groking and explaining license compatibility and documentation.

Thank you @fabpot !

@ghost
Copy link

ghost commented Apr 26, 2013

@jdorn: changing it to MIT would simplify things for many people.

@stof
Copy link
Member

stof commented Apr 27, 2013

FYI, it has been changed

@jdorn could you tag your release ?

@jdorn
Copy link

jdorn commented Apr 27, 2013

I just tagged it v1.2.9

@fabpot
Copy link
Member Author

fabpot commented Apr 30, 2013

ok, we now have only MIT/BSD license deps for Symfony SE.

fabpot added a commit that referenced this pull request Apr 30, 2013
This PR was merged into the master branch.

Discussion
----------

removed non-MIT/BSD licensed bundles (closes #442)

In #442, there is a discussion about the license of librairies and bundles included in the Symfony Standard Edition.

This pull requests removes all non-MIT/BSDlicensed code from Symfony SE. The impact is not that big and adding back those bundles is relatively easy.

Any thoughts before I merge?

Commits
-------

d84850a removed non-MIT/BSD licensed bundles and librairies
@fabpot fabpot merged commit d84850a into master Apr 30, 2013
bamarni added a commit to bamarni/symfony-standard that referenced this pull request May 14, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants