This repository was archived by the owner on Nov 27, 2020. It is now read-only.
dont hint the usage of the ApcuClassLoader anymore #964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the ApcuClassLoader isnt needed for PHP 5.6+ / PHP 7+ anymore, since Composer can now dump a OPCache optimized static classmap, that has similar performance characteristics also the ApcuClassLoader could cause problems with memory fragmentation for large apps see composer/composer#5174
|
👍 |
|
Still needed for php < 5.6 actually, shouldn't this PR be made over 2.8 instead of 2.3 ? |
|
IMO if you care about this level of performance you are on PHP5.6 or even 7 by now.. Upgrading PHP is the biggest win, not nitpicking with autoloaders :) Also this file is only used by new projects, older projects stuck on 5.4/5.5 will keep their file with the APC instructions, and new projects are more likely to be setup on new servers with up to date PHP. So all in all I'd say 👍 for just removing it. |
|
👍 |
1 similar comment
|
👍 |
|
Thank you @backbone87. |
Tobion
added a commit
that referenced
this pull request
Apr 12, 2016
…ne87) This PR was merged into the 2.3 branch. Discussion ---------- dont hint the usage of the ApcuClassLoader anymore the ApcuClassLoader isnt needed for PHP 5.6+ / PHP 7+ anymore, since Composer can now dump a OPCache optimized static classmap, that has similar performance characteristics also the ApcuClassLoader could cause problems with memory fragmentation for large apps see composer/composer#5174 Commits ------- 2acc49f dont hint the usage of the ApcuClassLoader anymore
xabbuh
added a commit
to symfony/symfony-docs
that referenced
this pull request
Nov 28, 2016
…" section (cristi-contiu) This PR was merged into the 2.8 branch. Discussion ---------- Update performance.rst - "Caching the Autoloader with APC" section The example provided under "Caching the Autoloader with APC" is not in sync with the content of the 'app.php' file in Symfony 2.8: - the comment hint was removed in symfony/symfony-standard#964 - the autoloader was extracted from bootstrap: symfony/symfony-standard@747a384 Even on PHP 5.6 with built-in OPcache, I still see a performance boost from enabling the ApcClassLoader. Commits ------- 4127ad9 Update performance.rst
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the ApcuClassLoader isnt needed for PHP 5.6+ / PHP 7+ anymore, since
Composer can now dump a OPCache optimized static classmap, that has
similar performance characteristics
also the ApcuClassLoader could cause problems with memory fragmentation
for large apps
see composer/composer#5174