Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

Document alternate locale handling #755

Merged
merged 1 commit into from
Apr 8, 2016
Merged

Document alternate locale handling #755

merged 1 commit into from
Apr 8, 2016

Conversation

dbu
Copy link
Member

@dbu dbu commented Apr 1, 2016

continuation of #691

Q A
Doc fix? no
New docs? yes
Applies to SeoBundle
Fixed tickets #605

This will be my first try to describe the alternate locales. I know the english is bad, but it can be a base for the documentation i hope.

Tasks:

  • configuration page changes
  • grammar review
  • chapter in intro

@dbu
Copy link
Member Author

dbu commented Apr 1, 2016

worked on the open issues from #691

@ElectricMaxxx do you want to review this one?

@ElectricMaxxx
Copy link
Member

Except the errors on travis it looks good to me.

@wouterj
Copy link
Member

wouterj commented Apr 2, 2016

travis failure is not related to this PR. It seems like the spell checker builder has trouble parsing the config options related to fabien's Sphinx extension.

When the alternate locale handling is set up and found alternates, you will
find links like the following in the ``<head>`` part of your HTML pages:

.. code-block: html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single colon should be a double one here

@wouterj
Copy link
Member

wouterj commented Apr 2, 2016

Nice article in general, thanks! Shouldn't this be merged into the 1.2 documentation (and then adding the notion about sitemaps in 1.3?)

@wouterj wouterj added review and removed wip/poc labels Apr 2, 2016
@dbu dbu force-pushed the alternate_locale_handling branch from 8a91458 to ba25ca9 Compare April 4, 2016 14:46
@dbu
Copy link
Member Author

dbu commented Apr 4, 2016

thanks a lot wouter for all that good feedback! i think i adressed all points.

strictly speaking yes, this could go into version 1.2. but not sure if we want to bother with that. i will squash the commits now, then if you want to pick it into 1.2 feel free to do so, otherwise lets just merge it into 1.3

@dbu dbu force-pushed the alternate_locale_handling branch 2 times, most recently from ab575f4 to aaf3231 Compare April 8, 2016 06:09
@dbu dbu force-pushed the alternate_locale_handling branch from aaf3231 to dec1ebf Compare April 8, 2016 06:17
@dbu dbu merged commit 74b48a2 into 1.3 Apr 8, 2016
@dbu dbu deleted the alternate_locale_handling branch April 8, 2016 06:22
@lsmith77 lsmith77 removed the review label Apr 8, 2016
@dbu
Copy link
Member Author

dbu commented Apr 8, 2016

cherry-picking this commit into the 1.2 branch leads to a lot of conflicts, so i decided to not bother with that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants