Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

update core bundle documentation for 2.0 #816

Merged
merged 1 commit into from
Apr 21, 2017
Merged

update core bundle documentation for 2.0 #816

merged 1 commit into from
Apr 21, 2017

Conversation

dbu
Copy link
Member

@dbu dbu commented Mar 8, 2017

part of #787

@dbu dbu added the wip/poc label Mar 8, 2017
@wouterj wouterj mentioned this pull request Mar 8, 2017
9 tasks
only needs to be changed when configuring multiple manager registries.

This setting is propagated as default value to all CMF bundles that support
this setting:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am rather surprised why the registry service name can be configured on search and simple bundle but not on any other. but as we already released them, i guess we have to leave that as is for now.

Copy link
Member

@ElectricMaxxx ElectricMaxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh i need to commit() the reviews :-)

just a litte sentence on the form_tab defintion

@@ -125,7 +119,8 @@ is the following configuration:

.. include:: ../_partials/persistence_phpcr_enabled.rst.inc

Enabling this setting will also automatically enable the equivalent setting in the following Bundles:
This setting is propagated as default value to all CMF bundles that support
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When they are installed(composer requirer, new ...() in kernel bundles)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right. added a note for that in the introduction (as this note is repeated for each setting that can be forwarded)

@@ -1,2 +1,221 @@
CoreBundle
==========

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add an hint, that this repository isn't stable atm - even when it gets stable next week.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding that hint to the introduction on the bundle


**type**: ``string`` **default**: as in above example.

Defines which form tab the fields from this extension will appear in within
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only, they also are passed into the translation so it is not a key only, it visible translated, so a non default key needs to be translated too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, added that

@dbu dbu force-pushed the core-doc-update branch from 002cbf5 to 752f2ec Compare April 21, 2017 13:27
@dbu dbu merged commit 9940951 into 2.0 Apr 21, 2017
@dbu dbu deleted the core-doc-update branch April 21, 2017 13:48
@dbu dbu removed the wip/poc label Apr 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants